Skip to content

feat: add blas/ext/base/ndarray/drev #9056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Amansingh0807 wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: add blas/ext/base/ndarray/drev #9056

Amansingh0807 wants to merge 6 commits into from
+738 −0

Conversation

@Amansingh0807
Copy link
Contributor

@Amansingh0807 Amansingh0807 commented Dec 15, 2025 •
edited
Loading

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/ndarray/drev

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

@Amansingh0807
feat: implement @stdlib/blas/ext/base/ndarray/drev
5debc39 
- Add ndarray wrapper for drev function
- Implement comprehensive test suite with stride/offset tests
- Add documentation (README, REPL, TypeScript types)
- Add examples and performance benchmarks
- Follow stdlib conventions for BLAS operations
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 15, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 15, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/drev $\color{green}102/102$
$\color{green}+0.00%$ 		$\color{green}3/3$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{green}102/102$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte reviewed Dec 15, 2025
View reviewed changes
lib/node_modules/@stdlib/blas/ext/base/ndarray/drev/docs/types/test.ts Outdated

// The function returns an ndarray...
{
const Float64Array = require( '@stdlib/array/float64' );
Copy link
Member

@kgryte kgryte Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No imports in blocks like this. See other packages.

Copy link
Contributor Author

@Amansingh0807 Amansingh0807 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. I've updated docs/types/test.ts to use top-level imports, consistent with other packages. Ready for review.

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Dec 16, 2025
kgryte
kgryte reviewed Dec 20, 2025
View reviewed changes
lib/node_modules/@stdlib/blas/ext/base/ndarray/drev/README.md Outdated

The function has the following parameters:

- **x**: input ndarray.
Copy link
Member

@kgryte kgryte Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct. We should always be providing an array of ndarrays. In this case, an array containing a single one-dimensional input ndarray.

kgryte
kgryte reviewed Dec 20, 2025
View reviewed changes
lib/node_modules/@stdlib/blas/ext/base/ndarray/drev/docs/types/index.d.ts Outdated
* drev( x );
* // x => <ndarray>[ 3.0, 2.0, 1.0 ]
*/
declare function drev( x: float64ndarray ): float64ndarray;
Copy link
Member

@kgryte kgryte Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fixed. All of these base/ndarray APIs need to always take an array of ndarrays. That is the expectation from higher level consumers.

kgryte
kgryte requested changes Dec 20, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments. In short, need to follow more closely the precedents established in other similar packages.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 20, 2025
@Amansingh0807 Amansingh0807 requested a review from kgryte January 5, 2026 07:37
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte Awaiting requested review from kgryte

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Amansingh0807 @stdlib-bot @kgryte