Skip to content

chore: fix JavaScript lint errors (issue #9965)#9968

Merged
kgryte merged 9 commits intostdlib-js:developfrom
SuYaSh-PaThAk04:chore/fix-js-lint-9965
Jan 29, 2026
Merged

chore: fix JavaScript lint errors (issue #9965)#9968
kgryte merged 9 commits intostdlib-js:developfrom
SuYaSh-PaThAk04:chore/fix-js-lint-9965

Conversation

@SuYaSh-PaThAk04
Copy link
Copy Markdown
Contributor

Resolves #resolves #9965.

Description

What is the purpose of this pull request?

This pull request:

  • refractered the string to pass eslint and refractered the function for unnecesary nesting

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • resolves #c

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jan 29, 2026
Comment thread lib/node_modules/@stdlib/nlp/expand-contractions/lib/index.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/repl/presentation/lib/commands/blank.js
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Jan 29, 2026
Comment thread lib/node_modules/@stdlib/nlp/expand-contractions/lib/index.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/nlp/expand-contractions/lib/index.js Outdated
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added the difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. label Jan 29, 2026
@SuYaSh-PaThAk04
Copy link
Copy Markdown
Contributor Author

@kgryte can we do something like
var str = "I'm ready.";
var out = expandContractions( str );
// returns 'I am ready.'

Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jan 29, 2026

@SuYaSh-PaThAk04 You were updating the wrong example.

@kgryte kgryte added review: 2 and removed Needs Review A pull request which needs code review. labels Jan 29, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jan 29, 2026

As the CI failure is not due to changes introduced in this PR, I'll go ahead and merge.

@kgryte kgryte merged commit d4045a4 into stdlib-js:develop Jan 29, 2026
28 of 30 checks passed
@SuYaSh-PaThAk04 SuYaSh-PaThAk04 deleted the chore/fix-js-lint-9965 branch January 29, 2026 09:30
DivitJain26 pushed a commit to DivitJain26/stdlib-divit that referenced this pull request Feb 25, 2026
PR-URL: stdlib-js#9968
Closes: stdlib-js#9965
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants