Add tests & slight refactor to TelegramTransport key handling#528
Merged
Conversation
eob
changed the title
dkolas
previously approved these changes
Aug 25, 2023
Contributor
dkolas
left a comment
dkolas
left a comment
There was a problem hiding this comment.
Looks good; I think this will help users be able to fix their existing bots without creating 1000 instances.
Minor request for a rename if you're up for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
This will enable a few nice things form a user perspective:
Follow-on work is a PR to do for Telegram what we just did for Slack in the web UI: