Skip to content

fix(telegram): ensure proper bot API base#557

Merged
douglas-reid merged 2 commits intomainfrom
doug/fix-transports-and-chat-history
Sep 26, 2023
Merged

fix(telegram): ensure proper bot API base#557
douglas-reid merged 2 commits intomainfrom
doug/fix-transports-and-chat-history

Conversation

@douglas-reid
Copy link
Copy Markdown
Contributor

I think that in the refactor in 05a8f0e the behavior of the base API for Telegram became to use a / in between bot and the supplied token.

Per https://core.telegram.org/bots/api#making-requests, the API base should be:

https://api.telegram.org/bot<token>/METHOD_NAME

Note the lack of / between bot and <token>

@douglas-reid douglas-reid requested review from dkolas and eob September 26, 2023 20:37
@douglas-reid douglas-reid force-pushed the doug/fix-transports-and-chat-history branch from 0313176 to 3889c6b Compare September 26, 2023 21:08
@douglas-reid douglas-reid force-pushed the doug/fix-transports-and-chat-history branch from 3889c6b to 1d85c35 Compare September 26, 2023 21:10
Copy link
Copy Markdown
Contributor

@eob eob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@douglas-reid douglas-reid added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 8694907 Sep 26, 2023
@douglas-reid douglas-reid deleted the doug/fix-transports-and-chat-history branch September 28, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants