swtpm: Write state files atomically using file renaming #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2718
💛 - Coveralls |
stefanberger
force-pushed
the
atomic_file_write
branch
from
e5c0d87 to
5082561
Compare
mz-pdm
approved these changes
Oct 5, 2020
src/swtpm/swtpm_nvfile.c
Outdated
| n = snprintf(filename, bufsize, "%s/tpm%s-%02lx.%s", | ||
| state_directory, suffix, (unsigned long)tpm_number, name); | ||
| if (is_tempfile) { | ||
| n = snprintf(filename, bufsize, "%s/TPM%s-%02lx.%s", |
There was a problem hiding this comment.
I hope that nobody ever gets an idea to run swtpm on a case-insensitive file system...
Owner
Author
There was a problem hiding this comment.
Will change this to TMP :-)
To support writing state files atomically we first write into a temporary file and then rename it. Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
stefanberger
force-pushed
the
atomic_file_write
branch
from
5082561 to
a8823a5
Compare
mz-pdm
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support writing state files atomically we first write into
a temporary file and then rename it.
Signed-off-by: Stefan Berger stefanb@linux.ibm.com