fix(reports): pageFooter uses injected report-language label instead of ambient locale (#1993)

client/src/components/reports/ReportContentEditor.test.tsx

@@ -106,6 +106,7 @@ const LABELS: ReportContentLabels = {
   sourceType: 'REPORT_SOURCE_TYPE_LABEL',
   reference: 'REPORT_REFERENCE_LABEL',
   generatedAt: 'REPORT_GENERATED_AT_LABEL',
+  pageLabel: 'REPORT_PAGE_LABEL',
 };
 
 function makeRow(overrides: Partial<ReportContentRow> = {}): ReportContentRow {

client/src/lib/reportContent/applyAiContent.test.ts

@@ -51,6 +51,7 @@ function makeLabels(): ReportContent['labels'] {
     sourceType: 'Source Type',
     reference: 'Reference',
     generatedAt: 'Generated At',
+    pageLabel: 'Page',
   };
 }
 

client/src/lib/reportContent/applyOverrides.test.ts

@@ -50,6 +50,7 @@ function makeLabels(): ReportContent['labels'] {
     sourceType: 'Source Type',
     reference: 'Reference',
     generatedAt: 'Generated At',
+    pageLabel: 'Page',
   };
 }
 

client/src/lib/reportContent/buildReportContent.ts

@@ -296,6 +296,7 @@ export function buildReportContent(
       sourceType: reportT('sourceReports.table.sourceType'),
       reference: reportT('sourceReports.table.reference'),
       generatedAt: reportT('sourceReports.table.generatedAt'),
+      pageLabel: reportT('sourceReports.table.pageLabel'),
     },
     sourceInfo,
     coverLetter,

client/src/lib/reportContent/types.ts

@@ -63,6 +63,7 @@ export interface ReportContentLabels {
   sourceType: string;
   reference: string;
   generatedAt: string;
+  pageLabel: string; // "Page N / M" label in the PDF footer, translated in report language
 }
 
 export interface ReportContent {

client/src/lib/reportPdf/coverLetterPdf.test.ts

@@ -57,6 +57,7 @@ function makeContent(overrides: Partial<ReportContent> = {}): ReportContent {
       sourceType: 'Source Type',
       reference: 'Reference',
       generatedAt: 'Generated At',
+      pageLabel: 'Page',
     },
     sourceInfo: {
       sourceName: 'Home Loan',

client/src/lib/reportPdf/merge.test.ts

@@ -211,6 +211,7 @@ function makeContent(overrides: Partial<ReportContent> = {}): ReportContent {
       sourceType: 'Source Type',
       reference: 'Reference',
       generatedAt: 'Generated At',
+      pageLabel: 'Page',
     },
     sourceInfo: {
       sourceName: 'Home Loan',
@@ -704,6 +705,7 @@ describe('generateReportPdf', () => {
 
     const sharedModule = (await import('./shared.js')) as unknown as {
       buildPageHeader: jest.Mock;
+      buildPageFooter: jest.Mock;
     };
     // #1938: the third arg is "label: value", not the bare i18n key — the label cannot silently
     // lose its value again. labels.generatedAt='Generated At', generatedAtText='01/15/2026'.
@@ -712,6 +714,10 @@ describe('generateReportPdf', () => {
       'My Source',
       'Generated At: 01/15/2026',
     );
+    // #1993: footer must use the injected report-language label, not the ambient UI locale t().
+    // content.labels.pageLabel='Page' (set in makeContent), so the call must receive that string,
+    // not t('sourceReports.table.pageLabel') from the UI locale.
+    expect(sharedModule.buildPageFooter).toHaveBeenCalledWith('Page');
 
     // [regression #1929] On current beta this is the hardcoded [40, 40, 40, 60] — the top margin
     // equaled the LEFT margin, not a value sized to the rendered page-header footprint, so the

client/src/lib/reportPdf/merge.ts

@@ -131,7 +131,7 @@ export async function generateReportPdf(
         `${reportContent.labels.generatedAt}: ${reportContent.sourceInfo.generatedAtText}`,
       );
     },
-    footer: buildPageFooter(t('sourceReports.table.pageLabel')),
+    footer: buildPageFooter(reportContent.labels.pageLabel),
     defaultStyle: PDF_DEFAULT_STYLE,
     styles: PDF_STYLES,
   });

client/src/lib/reportPdf/overviewPdf.test.ts

@@ -106,6 +106,7 @@ function makeLabels(): ReportContent['labels'] {
     sourceType: 'sourceReports.table.sourceType',
     reference: 'sourceReports.table.reference',
     generatedAt: 'sourceReports.table.generatedAt',
+    pageLabel: 'sourceReports.table.pageLabel',
   };
 }
 

client/src/lib/reportPdf/realRender.test.ts

@@ -2346,6 +2346,7 @@ describe('report PDF pipeline — real, unmocked end-to-end render', () => {
           sourceType: 'Source Type',
           reference: 'Reference',
           generatedAt: 'Generated At',
+          pageLabel: 'Page',
         },
         sourceInfo: {
           sourceName: 'Cell Scope Source',