Check blank localized strings

[kiranmagic7]

Summary

• Treat blank localized values as app-locale checker errors for every locale, not only strict locales.
• Add self-test coverage for blank-key detection.
• Fill the Vietnamese popup labels for Latest and Monthly; Latest was empty and Monthly reused the latest-label wording.

Proof

• node --check Scripts/check-app-locales.mjs passed.
• node Scripts/check-app-locales.mjs --test passed:

app locale checker tests OK

• node Scripts/check-app-locales.mjs passed:

App locales OK: Checked 20 catalogs against 1074 English keys.

• git diff --check passed.
• ./Scripts/lint.sh lint-macos passed:

app locale checker tests OK
App locales OK: Checked 20 catalogs against 1074 English keys.
0/1175 files require formatting.

• ./Scripts/lint.sh lint-linux passed:

Codex parser hash is current (800a06dead603ea7)
documentation links OK: 115 local links
llms index OK: docs/llms.txt
app/site locales OK: 21 locales, 50 site messages
Done linting! Found 0 violations, 0 serious in 1174 files.

Risk

Low. The script change only fails future locale checks when an existing localized key has a blank value, and the resource change fills two Vietnamese popup strings.

[clawsweeper]

Codex review: needs maintainer review before merge. Reviewed June 22, 2026, 8:51 PM ET / 00:51 UTC.

Summary
The PR updates the app locale checker to reject present-but-blank localized values for all locales, adds a self-test, and fills the Vietnamese Latest and Monthly strings.

Reproducibility: yes. from source inspection: current main contains an empty Vietnamese Latest value and the checker only fails blank values for strict locales. I could not run the script self-test in this Linux checkout because plutil is unavailable, but the code path is direct and the PR body/CI provide after-change output.

Review metrics: 1 noteworthy metric.

• Changed surface: 2 files, +17/-6. The patch is confined to one locale validation script and one Vietnamese resource catalog, so review stays focused.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

• none.

Next step before merge

• No ClawSweeper repair lane is needed because the open PR already contains a narrow implementation with sufficient proof and no blocking findings.

Security
Cleared: The diff only touches a local validation script and app string resources, with no dependency, workflow, secret, or supply-chain surface expansion.

Review details

Best possible solution:

Land the narrow checker/resource cleanup after ordinary maintainer review and normal CI gating.

Do we have a high-confidence way to reproduce the issue?

Yes from source inspection: current main contains an empty Vietnamese Latest value and the checker only fails blank values for strict locales. I could not run the script self-test in this Linux checkout because plutil is unavailable, but the code path is direct and the PR body/CI provide after-change output.

Is this the best way to solve the issue?

Yes. Checking present-but-blank localized values across all locales is the narrow maintainable fix, and filling the current Vietnamese values avoids making the stricter checker fail immediately.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against ef8007fc16ce.

Label changes

Label justifications:

• P3: This PR fixes a low-blast-radius localization checker gap and one visible Vietnamese label issue.
• rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body includes copied after-change terminal output for the locale checker, self-test mode, full app-locale check, diff check, and lint scripts.
• proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes copied after-change terminal output for the locale checker, self-test mode, full app-locale check, diff check, and lint scripts.

Evidence reviewed

What I checked:

• Repository policy read: AGENTS.md was read fully; its preference for focused CLI validation applies because this PR changes a locale-checker script and resource strings rather than app-bundle UI behavior. (AGENTS.md:1, ef8007fc16ce)
• Current checker gap: Current main only reports blank localized values as errors when the locale is in strictLocales, so a non-strict Vietnamese blank is skipped. (Scripts/check-app-locales.mjs:140, ef8007fc16ce)
• Current blank localized value: Current main leaves Vietnamese Latest blank and maps Monthly to the latest-label wording. (Sources/CodexBar/Resources/vi.lproj/Localizable.strings:778, ef8007fc16ce)
• Proposed checker behavior: The PR adds blankKeys, computes present-but-blank keys for each locale, and reports them as errors before the identical-value/token checks. (Scripts/check-app-locales.mjs:48, ee984c96d324)
• Proposed Vietnamese strings: The PR fills Vietnamese Latest with Mới nhất and Monthly with Hàng tháng. (Sources/CodexBar/Resources/vi.lproj/Localizable.strings:778, ee984c96d324)
• PR proof and CI context: The PR body includes after-change output for syntax check, self-test, full locale check, diff check, and lint scripts; GitHub also showed completed changes, lint, Linux build, and GitGuardian checks as successful at inspection time. (ee984c96d324)

Likely related people:

• steipete: Current-main blame and file history for the locale checker and Vietnamese catalog point to f380287, and earlier app/site language catalog alignment is also in this area. (role: recent area contributor; confidence: high; commits: f380287041b8, 9d197036cfba; files: Scripts/check-app-locales.mjs, Sources/CodexBar/Resources/vi.lproj/Localizable.strings)
• kiranmagic7: Git history shows this contributor previously landed current-main locale-checker work in merged commit 4700d8e. (role: recent area contributor; confidence: medium; commits: 4700d8e70f88; files: Scripts/check-app-locales.mjs)
• Yuxin-Qiao: Git history shows recent merged strict-locale health-check work in commit 1034e31. (role: adjacent i18n checker contributor; confidence: medium; commits: 1034e31b106f; files: Scripts/check-app-locales.mjs)

What the crustacean ranks mean

• 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
• 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
• 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
• 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
• 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
• 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
• 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.