Fix stale native menu hover highlight geometry

[Zihao-Qi]

Summary

• Defer geometry-changing root and hosted-submenu rebuilds while AppKit is highlighting a native row.
• Preserve the exact provider request and sticky readiness-baseline resync across scheduler replacement, native-highlight deferral, and an open hosted child.
• Keep that saved explicit provider authoritative when a dirty parent resumes after its hosted child closes.
• Resume one coalesced rebuild when the pointer leaves native rows; discard it cleanly when tracking closes.
• Add focused lifecycle, coalescing, fresh-menu, and hosted Status Page regressions.

Problem

When usage or status content refreshed while hovering native rows such as Plan Usage, Cost, or Open Status Page, AppKit could keep drawing the selection background using the old row geometry while the menu was rebuilt underneath it. This occasionally left the blue hover highlight over a different part of the menu.

Fix

Track the complete deferred rebuild request per open menu. Rebuild requests keep fetching and updating provider state, but any geometry-changing root or hosted-submenu mutation waits while a native item is highlighted. Coalesced requests retain readiness-baseline resync intent, and lifecycle cleanup removes deferred work when the menu closes.

Impact

Only visible menu layout mutation is briefly deferred while the pointer remains over a native row. Provider fetching, status items, widgets, and background updates continue normally.

Verification

Exact candidate: 94ccb89a96f426444e76d79d790c674ea1a9df7b

• Focused menu/lifecycle coverage: 187/187 tests across 3 suites passed, including both hosted-child close orders and the dirty-parent provider-precedence race.
• make check: passed.
• make test: 598/598 selections, 50/50 groups, zero failures, retries, or timeouts.
• Full-branch review plus final two-file autoreview: clean.
• Current main integration: clean merge tree after Default Agent Sessions to off #2039.
• Hosted CI/security: pending for the exact head.

Package verification used a Developer ID-signed normal exact-commit bundle. The controlled UI mutation used a separate strict-valid exact debug bundle with debug-only get-task-allow. Runtime used isolated home/config state, denied network and provider subprocess execution, and enabled both Keychain gates. A file-gated in-memory fixture recorded the real AppKit highlight state before mutation:

• Root: Plan Usage was a native highlighted row; root rebuild count stayed flat while highlighted, then increased exactly once after the pointer left. The menu stayed open with stable row geometry.
• Hosted Status Page submenu: Open Status Page was a native highlighted row; the API-only submenu remained unchanged while highlighted, then rebuilt exactly once after pointer exit and showed the added Dashboard row.
• Close while deferred: no late rebuild fired; reopening populated the new layout through the normal open path.
• Hosted-child provider race: the child closed with the dirty parent still natively highlighted and an explicit Claude rebuild saved. The callback re-deferred Claude while highlighted; after pointer exit exactly one rebuild ran, cleared the deferred state, marked the parent fresh, and visibly replaced the Codex placeholder with Claude actions. The generic Codex request never ran.

Local screenshots were retained as QA artifacts and were not uploaded.

Screenshot before

[clawsweeper]

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Fix stale native menu hover highlight geometry This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

[clawsweeper]

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Fix stale native menu hover highlight geometry This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3dbee5bad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[clawsweeper]

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Fix stale native menu hover highlight geometry This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

[clawsweeper]

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Fix stale native menu hover highlight geometry This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44e4f90bd2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[clawsweeper]

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Fix stale native menu hover highlight geometry This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

[clawsweeper]

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Fix stale native menu hover highlight geometry This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

[clawsweeper]

ClawSweeper status: review started.

I am starting a fresh review of this pull request: Fix stale native menu hover highlight geometry This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.