Fix Claude scoped weekly pace - #2372
Conversation
d7531ce to
47d3f8b
Compare
clawsweeper
Bot
added
rating: 🦪 silver shellfish
|
Codex review: needs real behavior proof before merge. Reviewed July 29, 2026, 12:01 PM ET / 16:01 UTC. ClawSweeper reviewWhat this changesThe PR enables reserve/deficit pace projections for Claude model-scoped seven-day rate windows and adds regression coverage for both weekly and non-weekly Claude extra windows. Merge readiness⛔ Blocked until real behavior proof is added - 2 items remain Keep this PR open. Current Priority: P2 Review scores
Verification
How this fits togetherCodexBar turns each provider usage snapshot into menu-card metrics shown from the macOS menu bar. Claude’s model-scoped quota limits arrive as extra rate windows, and the pace helper decides whether a metric gets reserve/deficit and run-out details or only usage and reset information. flowchart LR
A[Claude usage snapshot] --> B[Scoped extra rate windows]
B --> C[Menu-card metric builder]
C --> D{Seven-day Claude window?}
D -->|Yes| E[Pace calculation]
D -->|No| F[Usage and reset detail]
E --> G[Reserve or deficit display]
F --> H[Claude menu card]
G --> H
Before merge
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the provider-specific seven-day gate, merge it only after a redacted after-fix capture proves a real Claude scoped weekly card displays the expected reserve/deficit and projection, and retain the non-weekly regression guard. Do we have a high-confidence way to reproduce the issue? Yes, source-reproducible: a Claude extra window with Is this the best way to solve the issue? Yes. Adding Claude to the existing pace path while explicitly limiting its extra windows to seven days is the narrowest maintainable repair, and the companion non-weekly test protects the intended provider-specific boundary. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against c52b0efa13b0. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: Fix Claude scoped weekly pace This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
There was a problem hiding this comment.
Pull request overview
This PR enables pace projection details for Claude model-scoped weekly “extra rate windows” (7-day windows) so scoped weekly cards render the same reserve/deficit and run-out projection as the main weekly card, while keeping non-weekly extra windows unchanged.
Changes:
- Allow Claude weekly (10080-minute) extra rate windows to produce
PaceDetailin the menu card model helper. - Extend the Claude swap-account menu card regression test to assert pace details render for the
Fable onlyscoped weekly window. - Add a regression test ensuring Claude non-weekly extra windows do not render pace detail fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/CodexBar/MenuCardView+ModelHelpers.swift | Enables pace detail rendering for Claude weekly extra rate windows while preserving existing behavior for other non-weekly windows/providers. |
| Tests/CodexBarTests/MenuCardClaudeSwapAccountTests.swift | Adds/extends regression coverage to ensure Claude scoped weekly pace details appear and non-weekly extras remain without pace detail. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Merged after full verification. Claude model-scoped seven-day windows (e.g. "Fable only") now show reserve/deficit pace detail. Narrowed during review: the original guard enabled pace for any Claude extra window, which would have silently applied to any future 300-minute Claude window too — broader than the weekly fix intended. It's now restricted to Note on CI: the aggregate gate had been failing across reruns because |
Summary
Fable onlywindow in the Claude account-card regression testWhy
Claude model-scoped weekly limits are emitted as extra rate windows with a seven-day duration and reset date, so they contain everything the standard pace calculation needs. The extra-window pace helper was restricted to Codex and Antigravity, which left Claude's
Fable onlycard showing usage and reset information but no reserve/deficit or run-out projection.Impact
Claude scoped weekly cards now display the same pace detail as the main weekly card. Other providers and non-weekly extra windows remain unchanged.
Validation
git diff --checkFable onlycardsourcekitdInProc.framework