test: broaden provider gatekeeper to its full declared scope - #2704
Conversation
clawsweeper
Bot
added
rating: 🐚 platinum hermit
|
Codex review: needs maintainer review before merge. Reviewed August 6, 2026, 3:35 AM ET / 07:35 UTC. ClawSweeper reviewWhat this changesThe PR expands the provider-architecture gatekeeper’s lexical detection of raw lowercase provider IDs, records exact exceptions, and updates the provider guide. Merge readinessKeep open: this focused hardening is not yet on current main and has no actionable correctness finding. Likely related people: steipete (high confidence; feature owner and recent area contributor). Priority: P3 Review scores
Verification
How this fits togetherCodexBar’s provider architecture maps provider identifiers to descriptors, implementations, and local usage sources. The gatekeeper scans shipped Swift for unapproved cross-provider literals, directing contributors toward descriptor-driven boundaries or explicit documented exceptions. flowchart LR
A[Shipped Swift sources] --> B[Provider gatekeeper]
C[Provider ID catalog] --> B
B --> D{Allowed or suppressed?}
D -->|No| E[Test failure]
D -->|Yes| F[Documented provider boundary]
F --> G[Provider descriptors and usage paths]
Before merge
Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Land the focused gatekeeper expansion after the in-progress CI suite confirms this exact head. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a test and documentation hardening PR rather than a reported runtime defect; the focused scanner cases provide a source-level validation path. Is this the best way to solve the issue? Yes—the lexical tripwire remains deliberately scoped and uses exact line/token exceptions, while CodexHomeScope removes a duplicated default-path derivation. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against fb88548b02f3. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
1 participant
Implements the gatekeeper's declared scope fully instead of narrowing it: raw lowercase provider-ID literals now flag in every single-statement position (assignment, bare argument, dictionary key/value, array element, return), the labeled multiline dotted-case gap is closed, and the new hits were triaged honestly (one derivation through CodexHomeScope, truthful justifications, exact per-token suppressions). The out-of-scope list now contains only genuinely parser-requiring patterns, dynamic construction, Tests/**, and non-Swift files.
Proof: gatekeeper 37/37 zero findings, make check clean, full suite 821/821, Linux target builds, autoreview clean.
🤖 Generated with Claude Code