feat: cut over Synthetic, Poe, xAI, and z.ai to JavaScript on all platforms - #2758
Conversation
|
Codex review: needs changes before merge. Reviewed August 8, 2026, 1:16 AM ET / 05:16 UTC. ClawSweeper reviewWhat this changesThe PR makes Synthetic, Poe, xAI, and z.ai use bundled JavaScript usage providers on Apple and Linux, removing their duplicate Swift fetchers. Merge readinessKeep this owner-authored PR open, but it still has the previously reported P2 clock defect: Poe remains on host wall time despite the new injected plugin clock. Likely related person: steipete (high confidence from the portable-plugin and current cutover history). Priority: P2 Review scores
Verification
How this fits togetherProvider descriptors turn saved credentials and settings into normalized usage snapshots for CodexBar’s menu-bar cards and dashboards. This PR changes the execution layer that fetches and projects data for four API-token providers. flowchart LR
A[Provider credentials and settings] --> B[Provider descriptor]
B --> C[Bundled JavaScript provider]
C --> D[Normalized usage snapshot]
D --> E[Menu bar cards]
D --> F[Provider dashboard links]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Use Do we have a high-confidence way to reproduce the issue? Yes, by calling Poe’s plugin runtime with a fixed Is this the best way to solve the issue? No: the PR introduces Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 2161b06500d7. LabelsLabel justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (5 earlier review cycles)
|
The 0.15s interrupt must fire promptly, not wait out the hang; the 1s elapsed bound flaked at 1.66s on a loaded ARM64 runner. 5s still proves prompt termination against an unbounded loop.
The 0.3s stop signal must beat the 10s interval; the 2s elapsed bound flaked at 2.02s on a loaded x64 runner. 5s still proves prompt interruption.
ab7b966 to
624f1f4
Compare
Summary
Deliberate cookie-provider stops
OpenAI remains flag-gated, as do the four cookie providers whose JavaScript projections are proven but whose native orchestration still owns named behavior gaps:
Verification
make checkandmake build🤖 Generated with Claude Code