test: fix test compilation on Swift 6.3.3 - #2780
Merged
Merged
Conversation
…ed errors, cost-split call site)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FireworksUsageFetcherTestswith equivalent absolute-difference expectations.any Errorvalues toFireworksUsageErrorbefore asserting the exact expected cases.The Fireworks tests landed in #2687 after its CI runs were cancelled, so Swift 6.3.3 never compiled these assertions. Separately, the cost-split signature changed after the #2763 scale-proof tests landed, leaving that fixture call site stale.
This is test-only and unblocks CI test compilation for all in-flight PRs.
Validation
swift build --build-testsswift test --filter "FireworksUsageFetcherTests|CostUsageStoreScaleProofTests"(12 tests passed)make checkreaches a pre-existingorigin/maindocumentation consistency failure: provider manifests report 68 providers whileREADME.mdadvertises 67. That unrelated file is intentionally outside this test-only patch.