fix(browser): preserve Deep Research selection through submit#282
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 1, 2026, 5:53 AM ET / 09:53 UTC. Summary Reproducibility: no. not with high-confidence live reproduction here: I did not run the long ChatGPT Pro browser smoke. The linked issue and current source make the failing activation boundary source-reproducible against main. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow browser fix after the contributor or a maintainer attaches redacted live proof showing the submitted Do we have a high-confidence way to reproduce the issue? No, not with high-confidence live reproduction here: I did not run the long ChatGPT Pro browser smoke. The linked issue and current source make the failing activation boundary source-reproducible against main. Is this the best way to solve the issue? Likely yes: moving Deep Research activation after the final composer reset/upload and supporting the current tools-menu DOM is a narrow maintainable fix. The remaining gap is proof, not an alternate implementation path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 56531a38734b. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
b941bc8 to
888992c
Compare
steipete
left a comment
There was a problem hiding this comment.
Maintainer review complete. The submit-order fix, current tools-menu DOM handling, trusted click fallback, regression coverage, and documentation all fit the browser-engine contract. Focused tests, full checks/build, clean autoreview, and authenticated normal plus Deep Research browser runs passed on the updated head.
Record upstream/main (bda0326) as merged. The fork already contains equivalent implementations for upstream PRs steipete#276, steipete#277, steipete#278, and steipete#282 from the prior sync. Keep the fork tree unchanged to avoid overwriting unrelated in-progress local lane work.
Summary
.__menu-itemrows andDeep research/Get a detailed reportlabels.Fixes #281.
Verification
pnpm vitest run tests/browser/deepResearch.test.ts tests/browser/promptComposer.test.ts tests/browser/index.test.ts tests/cli/browserConfig.test.ts— 164 passed.pnpm run check— passed.pnpm run build— passed.Live ChatGPT proof
Authenticated ChatGPT browser runs against this exact implementation:
Clicked send button.--browser-research deeploggedDeep Research mode activated, submitted the user turn with the visibleDeep researchmarker, displayed the active research plan/task UI, completed the research run, and returned the requested current OpenAI Help Center source: https://help.openai.com/en/articles/10500283-deep-research-in-chatgptNo connected apps or private data were used for the research request.