chore(deps): refresh stabilized dependencies and repair Node 24 test image - #403
Conversation
Bumps the dependencies group with 3 updates: [happy-dom](https://github.com/capricorn86/happy-dom), [markdown-it](https://github.com/markdown-it/markdown-it) and [mediabunny](https://github.com/Vanilagy/mediabunny). Updates `happy-dom` from 20.11.6 to 20.11.12 - [Release notes](https://github.com/capricorn86/happy-dom/releases) - [Commits](capricorn86/happy-dom@v20.11.6...v20.11.12) Updates `markdown-it` from 15.0.0 to 15.0.1 - [Changelog](https://github.com/markdown-it/markdown-it/blob/master/CHANGELOG.md) - [Commits](markdown-it/markdown-it@15.0.0...15.0.1) Updates `mediabunny` from 1.55.2 to 1.55.3 - [Release notes](https://github.com/Vanilagy/mediabunny/releases) - [Commits](Vanilagy/mediabunny@v1.55.2...v1.55.3) --- updated-dependencies: - dependency-name: happy-dom dependency-version: 20.11.12 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: markdown-it dependency-version: 15.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: mediabunny dependency-version: 1.55.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Align the workspace toolchain and test container, retain security patches, and retry transient Chromium profile cleanup. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Codex review: blocked before merge. Reviewed September 4, 2026, 5:36 AM ET / 09:36 UTC. ClawSweeper reviewWhat this changesThe PR updates stabilized dependencies, makes the Docker test image use the workspace’s Node 24 and pnpm setup, and retries transient Chromium-profile cleanup. Merge readiness⛔ Blocked before merge - 3 items remain Keep open: the Node 24 container repair and dependency refresh are otherwise well-supported, but the PR adds a release-note entry contrary to the repository contribution policy. Priority: P3 Review scores
Verification
How this fits togetherThe pnpm workspace builds the core library before the CLI, while Dockerfile.test packages that build together with ffmpeg and yt-dlp for command-line extraction checks. The container consumes the root manifest, lockfile, workspace configuration, core package, and vendored ffmpeg assets. flowchart LR
Manifest[Workspace manifest and lockfile] --> Install[Frozen pnpm install]
Core[Core library sources] --> Build[Core and CLI build]
Install --> Build
Build --> Image[Node 24 test image]
Image --> Extraction[CLI extraction run]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Remove the PR-authored changelog line, then land the validated Node 24 workspace-image repair and dependency updates; release maintainers can add the final entry when landing. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a maintenance PR, not a report of an end-user defect. Is this the best way to solve the issue? No: the changelog edit is not the repository’s intended release-note workflow; removing that one line preserves the narrow technical solution. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f3ad717a3f92. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
Refresh the stabilized dependency set and make the CLI test container build against the workspace's declared Node 24 runtime. The previous Dockerfile still used Node 22 and an obsolete pnpm bootstrap, omitted the workspace/core package and local security patch inputs, and removed the root prepare script. It now selects pnpm from package.json, copies the required workspace inputs, and runs the normal frozen install and build.
Retain Dependabot's happy-dom 20.11.12, markdown-it 15.0.1, and mediabunny 1.55.3 updates; add Sharp 0.35.4, protobufjs 7.6.6, and pnpm 11.24.0. All six versions and all 33 newly introduced lockfile package identities satisfy the seven-day stabilization policy. Runtime floors and existing image-size security patches are preserved. Documentation and a runtime/toolchain alignment regression test cover the container setup.
Publication dates were independently read from the npm registry on September 4, 2026:
The Chromium run also exposed an existing temporary-profile cleanup race: teardown raised ENOTEMPTY while removing the profile. The harness now uses five bounded filesystem retries with 100ms linear backoff; it still reports a cleanup failure if retries are exhausted.
Validation on Node 24:
pnpm -s check: 3,025 passed / 43 skipped tests; coverage above all required thresholds. Frozen install and CLI/core build passed with pnpm 11.24.0.7f4f5be53b1b0b549be74eb2b6ac3fffca7394b9: Node 24 tests/build/pack, Chromium E2E, and Firefox smoke all succeeded.A fresh
pnpm auditrequest timed out, including one bounded retry. The earlier audit reported two image-size advisories covered by the existing local patch; that is historical evidence, not a new successful audit. The patch and its regression tests remain intact.Dependabot's original commit is retained, with the remaining changes in a normal maintainer follow-up. This PR is prepared for maintainer review and has not been merged.