Skip to content

fix: prevent duplicate compatibility text boxes - #476

Merged
jan-kubica merged 1 commit into
mainfrom
fix/stabilize-drawing-shape-roundtrip
Jul 23, 2026
Merged

fix: prevent duplicate compatibility text boxes#476
jan-kubica merged 1 commit into
mainfrom
fix/stabilize-drawing-shape-roundtrip

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor

Summary

  • give modern DrawingML text boxes exclusive ownership of their VML compatibility fallback
  • keep pure VML text boxes editable without also generating preview drawings
  • preserve image-backed mixed VML text boxes as one conservative raw drawing

Validation

  • focused parser and save/reopen ownership tests (28 passed)
  • core suite and isolated timing-sensitive reruns
  • lint, typecheck, and formatting
  • build and clean-room distribution validation
  • changeset check
  • dependency audit

@jan-kubica
jan-kubica marked this pull request as ready for review July 23, 2026 19:48
@jan-kubica

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

CC on behalf of @jan-kubica

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jan-kubica, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a175264-b563-484f-a215-b87f27c67d71

📥 Commits

Reviewing files that changed from the base of the PR and between 7f5ab65 and 82a59be.

📒 Files selected for processing (5)
  • .changeset/quiet-textboxes-rest.md
  • packages/core/src/docx/paragraphTextBoxEnrichment.ts
  • packages/core/src/docx/runParser.ts
  • packages/core/src/docx/textBoxDrawingOwnership.test.ts
  • packages/core/src/docx/vmlImageParser.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/stabilize-drawing-shape-roundtrip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

@jan-kubica I’ll review the changes in #476, focusing on DrawingML/VML ownership and round-trip behaviour.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jan-kubica
jan-kubica force-pushed the fix/stabilize-drawing-shape-roundtrip branch from 99410e3 to 82a59be Compare July 23, 2026 20:02
@jan-kubica
jan-kubica merged commit b166291 into main Jul 23, 2026
8 checks passed
@jan-kubica
jan-kubica deleted the fix/stabilize-drawing-shape-roundtrip branch July 23, 2026 20:08
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant