Skip to content

Bump Helm Chart Version for publishing, add anchor_callback parameter to documentation#446

Merged
reecexlm merged 22 commits into
mainfrom
bump-helm-chart-version
Aug 2, 2022
Merged

Bump Helm Chart Version for publishing, add anchor_callback parameter to documentation#446
reecexlm merged 22 commits into
mainfrom
bump-helm-chart-version

Conversation

@reecexlm

Copy link
Copy Markdown
Contributor

Update Helm Chart version to 0.3.85 in preparation to publish new chart
Add anchor_callback and integration_auth parameters to documentation
add reference to anchor platform default values

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@stellar-jenkins

Copy link
Copy Markdown

Something went wrong with PR preview build please check

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@stellar-jenkins

Copy link
Copy Markdown

Something went wrong with PR preview build please check

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@stellar-jenkins

Copy link
Copy Markdown

Something went wrong with PR preview build please check

@stellar-jenkins

Copy link
Copy Markdown

Something went wrong with PR preview build please check

@stellar-jenkins

Copy link
Copy Markdown

Something went wrong with PR preview build please check

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@erika-sdf erika-sdf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just requesting a change to fill out some missing columns

Comment thread helm-charts/sep-service/readme.md Outdated
Comment on lines +104 to +108
| stellar.app_config.app.integration_auth.auth_type | NONE, JWT_TOKEN, API_KEY | NONE |
| stellar.app_config.app.integration_auth.platformToAnchorSecret | secret value | ${PLATFORM_TO_ANCHOR_SECRET} |
| stellar.app_config.app.integration_auth.anchorToPlatformSecret | secret value | ${ANCHOR_TO_PLATFORM_SECRET} |
| stellar.app_config.app.integration_auth.expirationMilliseconds | Expiration ms | 30000 |
| stellar.app_config.app.anchor_callback | unique address endpoint | NONE |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these rows are missing the description column

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated! thanks for catching this!

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

1 similar comment
@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@stellar-jenkins

Copy link
Copy Markdown

Something went wrong with PR preview build please check

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@erika-sdf erika-sdf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr446.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr446.previews.kube001.services.stellar-ops.com/

@reecexlm reecexlm merged commit 021f436 into main Aug 2, 2022
@reecexlm reecexlm deleted the bump-helm-chart-version branch August 2, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants