Skip to content

hotfix: CI was not being executed in the develop branch after merging#513

Merged
marcelosalloum merged 2 commits into
developfrom
hotfix/fix-ci-not-being-executed-after-merge
Aug 19, 2022
Merged

hotfix: CI was not being executed in the develop branch after merging#513
marcelosalloum merged 2 commits into
developfrom
hotfix/fix-ci-not-being-executed-after-merge

Conversation

@marcelosalloum

Copy link
Copy Markdown
Contributor
PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

Fix CI not being executed in the develop branch after merging.

Why

After we changed the default branch to develop, we hadn't updated the CI to run on the new default branch (after merging PRs).

@marcelosalloum marcelosalloum added bug Something isn't working gitflow labels Aug 19, 2022
@marcelosalloum marcelosalloum self-assigned this Aug 19, 2022
@marcelosalloum marcelosalloum requested a review from a team August 19, 2022 17:08
@marcelosalloum marcelosalloum marked this pull request as ready for review August 19, 2022 17:08

@lijamie98 lijamie98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr513.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr513.previews.kube001.services.stellar-ops.com/

@stellar-jenkins

Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr513.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr513.previews.kube001.services.stellar-ops.com/

@marcelosalloum marcelosalloum merged commit 64ee617 into develop Aug 19, 2022
@marcelosalloum marcelosalloum deleted the hotfix/fix-ci-not-being-executed-after-merge branch August 19, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gitflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants