Skip to content

Feature: stellar observer retry with exponential back-off timer#607

Merged
marcelosalloum merged 14 commits intorelease/1.2.0from
feature/stellar-observer-retry
Sep 30, 2022
Merged

Feature: stellar observer retry with exponential back-off timer#607
marcelosalloum merged 14 commits intorelease/1.2.0from
feature/stellar-observer-retry

Conversation

@marcelosalloum
Copy link
Copy Markdown
Contributor

@marcelosalloum marcelosalloum commented Sep 29, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    paymentservice.stellar, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.

What

Add retry and exponential back-off to the stellar observer when the queue is offline.

Why

Close #293.

@marcelosalloum marcelosalloum self-assigned this Sep 29, 2022
@marcelosalloum marcelosalloum changed the base branch from develop to feature/add-health-check-to-stellar-observer September 29, 2022 22:07
@marcelosalloum marcelosalloum force-pushed the feature/stellar-observer-retry branch from 95a899f to 3d14019 Compare September 29, 2022 22:07
@marcelosalloum marcelosalloum force-pushed the feature/add-health-check-to-stellar-observer branch from df39ec3 to 8b11a33 Compare September 30, 2022 00:07
@marcelosalloum marcelosalloum force-pushed the feature/stellar-observer-retry branch from 3d14019 to 6cd163f Compare September 30, 2022 00:08
@marcelosalloum marcelosalloum requested a review from a team September 30, 2022 00:09
@marcelosalloum marcelosalloum marked this pull request as ready for review September 30, 2022 00:09
@marcelosalloum marcelosalloum force-pushed the feature/stellar-observer-retry branch 2 times, most recently from 82f8525 to 0734529 Compare September 30, 2022 00:54
@stellar stellar deleted a comment from stellar-jenkins Sep 30, 2022
@stellar stellar deleted a comment from stellar-jenkins Sep 30, 2022
@stellar stellar deleted a comment from stellar-jenkins Sep 30, 2022
@stellar stellar deleted a comment from stellar-jenkins Sep 30, 2022
@stellar-jenkins
Copy link
Copy Markdown

Something went wrong with PR preview build please check

@marcelosalloum marcelosalloum force-pushed the feature/stellar-observer-retry branch from 0734529 to 7e219bc Compare September 30, 2022 00:59
@stellar-jenkins
Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr607.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr607.previews.kube001.services.stellar-ops.com/

Comment thread core/src/main/java/org/stellar/anchor/event/KafkaEventService.java Outdated
@marcelosalloum marcelosalloum changed the title Feature: stellar observer retry Feature: stellar observer retry with exponential back-off timer Sep 30, 2022
@marcelosalloum marcelosalloum force-pushed the feature/stellar-observer-retry branch from 7e219bc to 0b1c357 Compare September 30, 2022 18:54
@stellar-jenkins
Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr607.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr607.previews.kube001.services.stellar-ops.com/

@stellar-jenkins
Copy link
Copy Markdown

Reference Server Preview is available here:
https://anchor-ref-pr607.previews.kube001.services.stellar-ops.com/
SEP Server Preview is available here:
https://anchor-sep-pr607.previews.kube001.services.stellar-ops.com/

Copy link
Copy Markdown
Contributor

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feature/add-health-check-to-stellar-observer to release/1.2.0 September 30, 2022 21:12
@marcelosalloum marcelosalloum merged commit 840eecd into release/1.2.0 Sep 30, 2022
@marcelosalloum marcelosalloum deleted the feature/stellar-observer-retry branch September 30, 2022 21:13
@lijamie98 lijamie98 mentioned this pull request Oct 5, 2022
4 tasks
marcelosalloum added a commit that referenced this pull request Oct 6, 2022
### What

Add retry and exponential back-off to the stellar observer when the queue is offline.

### Why

Close #293.
@marcelosalloum marcelosalloum mentioned this pull request Oct 6, 2022
12 tasks
marcelosalloum added a commit that referenced this pull request Oct 7, 2022
### What

- [x] #608 
- [x] #602 
- [x] #607 
- [x] #610
- [x] Add `1.2.0` version to the changelog.
- [x] #618
- [x] #612 

### Why

To merge Release 1.2.0 into dev.
lijamie98 added a commit that referenced this pull request Oct 11, 2022
* log test results (#608)
* add health check to stellar observer (#602)
* stellar observer retry with exponential back-off timer (#607)
* update helm chart by exposing the metrics port to the internal network (#610)
* expose the `8082` metrics port to the internal network.
* add `deployment.annotations` to the example values.
* delete duplicate appearance of `ORG_URL` in the example values.
* updated the version string and the change log
* allow refund status to patch transaction (#618)
* fix: stop crashing when parsing response content into ErrorResponse (#612)
* separate observer deployment (#613)
* remove basic tests from release_main.yml, release_release.yml to avoid duplicating tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle queue downtime in the Stellar Observer, possibly with exponential backoff

3 participants