Skip to content

Add 'hide dust payments' preference toggle #261

Merged
leofelix077 merged 4 commits intomainfrom
lf-settings-hide-small-payments
Aug 11, 2025
Merged

Add 'hide dust payments' preference toggle #261
leofelix077 merged 4 commits intomainfrom
lf-settings-hide-small-payments

Conversation

@leofelix077
Copy link
Copy Markdown
Collaborator

Closes #247

Tests done with asset_type 'credit_alphanum4' instead of 'native'

Screen.Recording.2025-08-08.at.11.56.56.mov

@leofelix077 leofelix077 self-assigned this Aug 8, 2025
@danilosilvackl danilosilvackl added the enhancement New feature or request label Aug 8, 2025
@danilosilvackl danilosilvackl added this to the Freighter Mobile - V1 milestone Aug 8, 2025
Comment thread src/hooks/useGetHistoryData.ts Outdated
Comment thread src/hooks/useGetHistoryData.ts Outdated
@CassioMG
Copy link
Copy Markdown
Contributor

CassioMG commented Aug 8, 2025

Closes #247

Tests done with asset_type 'credit_alphanum4' instead of 'native'

Screen.Recording.2025-08-08.at.11.56.56.mov

it took a while for me to realize it, but I think on your video the payments are being hidden because you are swapping a small amount of XLM for SSLX. Is that right? And not because we have small amounts of SSLX which is actually the desired behavior since we are only interested in XLM here so no changes needed. I'm highlighting it here just in case someone else has the same question because the History rows do not display the XLM amounts, only the SSLX amounts so it's not so easy to notice what is actually happening.

@CassioMG CassioMG removed this from the Freighter Mobile - V1 milestone Aug 8, 2025
@leofelix077
Copy link
Copy Markdown
Collaborator Author

@CassioMG yes. I mentioned on the description about the flip. At the moment i don't have residual payments in my account, so I switched the asset type in code for testing and reverted before committing

@leofelix077
Copy link
Copy Markdown
Collaborator Author

Resolved previous conversations, and replying to all here:

as agreed during our call -> will revert the changes to keep it more in line with the extension and have the fetchData fn resolve the isHideDustEnabled. Side-effects: more network calls -> to be adjusted globally in a future version in all cases

@CassioMG
Copy link
Copy Markdown
Contributor

CassioMG commented Aug 8, 2025

@CassioMG yes. I mentioned on the description about the flip. At the moment i don't have residual payments in my account, so I switched the asset type in code for testing and reverted before committing

Ah ok, now I understand what you mentioned by the description

Copy link
Copy Markdown
Contributor

@danilosilvackl danilosilvackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@leofelix077 leofelix077 merged commit d523bfc into main Aug 11, 2025
2 checks passed
@leofelix077 leofelix077 deleted the lf-settings-hide-small-payments branch August 11, 2025 21:32
@github-actions github-actions Bot mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Settings - Hide small payments

4 participants