Skip to content

Add Transaction Settings Extra info Bottom Sheets + Missing JSDoc#273

Merged
leofelix077 merged 30 commits intomainfrom
lf-memo-addr-jsdoc-and-settings-info
Aug 18, 2025
Merged

Add Transaction Settings Extra info Bottom Sheets + Missing JSDoc#273
leofelix077 merged 30 commits intomainfrom
lf-memo-addr-jsdoc-and-settings-info

Conversation

@leofelix077
Copy link
Copy Markdown
Collaborator

Added as a separate PR not to clutter the already in-review #268

Adds missing info sections for the transaction settings and some missing JSDocs from the new implementations/components

Screen.Recording.2025-08-15.at.13.16.18.mov

lfelixckl and others added 27 commits August 8, 2025 11:36
@leofelix077 leofelix077 self-assigned this Aug 15, 2025
Comment thread src/providers/WalletKitProvider.tsx
@CassioMG
Copy link
Copy Markdown
Contributor

@leofelix077 does the "X" button have a border here? I think it shouldn't have the border
Screenshot 2025-08-15 at 12 15 08

Base automatically changed from lf-validation-memo-addresses to main August 15, 2025 21:58
@leofelix077
Copy link
Copy Markdown
Collaborator Author

@CassioMG I didnt wanna change it now because it's part of the base Icon component circle and circleBackground are kind of interconnected, and the base component has the border. to leave it for the rest of the redesigns, not to create a custom component or leave it inconsistent

@CassioMG
Copy link
Copy Markdown
Contributor

@CassioMG I didnt wanna change it now because it's part of the base Icon component circle and circleBackground are kind of interconnected, and the base component has the border. to leave it for the rest of the redesigns, not to create a custom component or leave it inconsistent

makes sense, let's keep the border now then we can update the icon component when we do the design polishes

@leofelix077 leofelix077 merged commit 2d7cf33 into main Aug 18, 2025
2 checks passed
@leofelix077 leofelix077 deleted the lf-memo-addr-jsdoc-and-settings-info branch August 18, 2025 13:50
@github-actions github-actions Bot mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants