Skip to content

[Blockaid] Search Asset Flow#301

Merged
danilosilvackl merged 38 commits intomainfrom
ds-blockaid-search-tokens
Aug 26, 2025
Merged

[Blockaid] Search Asset Flow#301
danilosilvackl merged 38 commits intomainfrom
ds-blockaid-search-tokens

Conversation

@danilosilvackl
Copy link
Copy Markdown
Contributor

Added blockaid scan token to the Add token screen

  • Scan tokens when user search for a new token
  • Order tokens before showing using the following order
    1. Bening
    2. Suspicious
    3. Malicious

iOS 

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-25.at.11.01.08.mp4

Android 🤖

android_token_search.webm

closes #210

fix: updated copy on dapp connection bottom sheet
feat: update stellar-sdk to stable version

fix: correct contract id cast
chore: remove logger
chore: switch assets mentions to token
@danilosilvackl danilosilvackl self-assigned this Aug 25, 2025
@danilosilvackl danilosilvackl added the enhancement New feature or request label Aug 25, 2025
@danilosilvackl danilosilvackl requested review from a team, CassioMG and leofelix077 August 25, 2025 14:26
@JakeUrban
Copy link
Copy Markdown
Contributor

Why is SSLX the first result in that first video?

@JakeUrban
Copy link
Copy Markdown
Contributor

Also something to call out: we're getting search results from stellar.expert which are already sorted by its own criteria. So we should maintain its sort order within each blockaid status. Meaning, for all "safe" tokens, the order should be the same as returned by stellar.expert, and then all "suspicious" tokens should come next in the same order they were returned from stellar.expert, etc.

@danilosilvackl
Copy link
Copy Markdown
Contributor Author

@JakeUrban thanks for the insight on that, the first thing is that we were reordering the entire list based on:
has_trustline > security ordering
now I reworked the results to follow the rules you mentioned, its looking like this now:
simulator_screenshot_DDE42EF7-C929-40ED-A6A8-AAC22C0CAAAF


try {
if (!isMainnet(network)) {
throw new Error(BLOCKAID_ERROR_MESSAGES.NETWORK_NOT_SUPPORTED);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you confirm it won't block the flow on Testnet?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just check to make sure, it doesn't block since we have the try catch on the lookup, if the scan fails we just follow up with whatever we got from the stellar expert

Base automatically changed from ds-sign-transaction-blockaid to main August 26, 2025 13:08
@danilosilvackl danilosilvackl merged commit e0bf3f8 into main Aug 26, 2025
2 checks passed
@danilosilvackl danilosilvackl deleted the ds-blockaid-search-tokens branch August 26, 2025 13:19
@github-actions github-actions Bot mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Blockaid] Search Asset Flow

3 participants