[FEAT] History list improvements by danilosilvackl · Pull Request #342 · stellar/freighter-mobile

danilosilvackl · 2025-09-09T00:07:28Z

We created a new history store for managing history data

it handles the initial fetching of the data
the polling for next history updates (30s)
when and where to update
different filtered lists (filtered by token or to hide received payments smaller than 0.1 XLM)
programmatically update after swap or send transactions
manual loading to simulate the pull to refresh spinner when updating from swap or send transactions

iOS 

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-09-08.at.20.25.55.mp4

Android 🤖

Screen_recording_20250908_210638.mp4

closes #300
closes #299

leofelix077 · 2025-09-11T12:39:01Z

+      const year = date.getFullYear();
+      const monthYear = `${month}:${year}`;
+
+      const lastSection = sections.length > 0 && sections[sections.length - 1];


minor: do you need both checks? directly sections[sections.length -1] or !!sections.length would already identify it

@leofelix077 what would happen when we have this case: const lastSection = sections[-1] ?

I think javascript does not support it

hummm it appears it would result in lastSection = undefined on javascript, which would work in this case. But I'd test it to make sure

in JS an array is just an object under the hood at the end of day

const myArray = { 0: 'firstItem' 1: 'someitem' }

myArray[-1] is undefined

nice one, done!

leofelix077 · 2025-09-11T12:42:41Z

+
+      const { fetchAccountBalances, getBalances } = useBalancesStore.getState();
+
+      await fetchAccountBalances({


can this be a Promise.all with the getAccountHistory?

leofelix077 · 2025-09-11T12:44:57Z

+      history: historySections,
+    };
+  },
+  startPolling: (params) => {


general question: why do we need the polling?

the initial idea was to keep the same pattern we use for balances where we have a central polling (on TabNavigator) which updates balances every 30 seconds. But it appears on this PR we don't have a central history polling but instead it starts/stops polling whenever users navigate to History screens which I agree does not seem very effective.

Ideally I think we should either have a central and constant polling or don't have the polling at all then just trigger a background refresh whenever user visits a history list (and take care not run concurrent history fetching).

Yeah, the way I first did was wrong (polling only after it was fetched the first time). Now we are using a centralized polling system like the balance list

leofelix077 · 2025-09-11T12:46:58Z

+    error: shouldShowError ? error : null,
+    isLoading: shouldShowFullScreenLoading,
+    isRefreshing,
+    isNavigationRefresh: isNavigationRefresh || shouldRefreshAfterNavigation,


maybe we could have a useFocusEffect instead a param to refresh after navigation?

I'm not against using useFocusEffect, but in case we decide on fetching history every time users navigate to history we will need to take care not to stack duplicate requests since it's a pretty heavy request

since the idea is to prevent the fetch to happen every time we visit this screen, I prefer to stick with the param.
we have a controlled way to refresh, in this case we only force this refresh when we navigate from we finish a swap or send transaction

I think the shouldRefreshAfterNavigation param works, but I have a suggestion to make it less specific so it's potentially easier to main:

I'm thinking maybe we could call something like fetchAccountHistory({ hasRecentTransaction }) right after the transaction submission is complete (or right before navigating to the history screen). Then on History screen we display the CustomRefreshIndicator if hasRecentTransaction && isFetching as I'm understanding that the goal of the custom shouldRefreshAfterNavigation param is to display the CustomRefreshIndicator so we make it clear for users that History is being updated after a recent transaction has been submitted.

Also, if users stay on the "Transaction Success" screen long enough for the fetchAccountHistory({ hasRecentTransaction }) fetching to complete I think it's fine to not display the CustomRefreshIndicator when they navigate to History as the recent transaction should already be appearing there.

What do you think?

makes sense, I made the change and this helped to tone down the amount of code by a fair bit, thanks for the suggestion

leofelix077 · 2025-09-11T12:47:47Z

    },
    "hideDust": {
-      "title": "Hide small payments",
+      "title": "Hide received payments smaller than 0.1 XLM",


is this intended? this is on the preferences screen. the title will break in two lines

I think the title here should remain Hide small payments and the description should be updated to Hide received payments smaller than 0.1 XLM

oh, my mistake, fixed!

CassioMG · 2025-09-11T23:14:33Z

+ * This is typically called after completing a transaction (send/swap) to ensure
+ * the latest transaction appears in the history with a smooth UX
+ */
+export const markHistoryForRefreshAfterTransaction = () => {


curious on why you've chosen to create a helper for it in place of calling markForRefreshAfterNavigation() directly on the components

it was actually redundant, removed

CassioMG · 2025-09-11T23:16:13Z

    },
    "hideDust": {
-      "title": "Ocultar pagamentos pequenos",
+      "title": "Ocultar pagamentos recebidos menores que 0.1 XLM",


same thing here

CassioMG · 2025-09-11T23:24:32Z

        {ListHeaderComponent}
        <HistoryWrapper>
-          <Spinner testID="spinner" />
+          <Spinner size="small" testID="spinner" />


could we make it a large spinner? I think it would look better since History takes a lot of space

fix: removed unecessary code for centralized polling on balancesList

fix: removed unecessary helper function

danilosilvackl · 2025-09-17T15:23:14Z

@CassioMG @leofelix077 also added the improvement to the pull to refresh from #299

Before

before.mov

After

after.mov

CassioMG · 2025-09-17T23:11:02Z


    // Mark history to refresh when user navigates to history screen
-    markHistoryForRefreshAfterTransaction();
+    useHistoryStore.getState().markForRefreshAfterNavigation();


why not extracting it at the beginning of the component?

const { markForRefreshAfterNavigation } = useHistoryStore();

CassioMG · 2025-09-17T23:11:40Z


    // Mark history to refresh when user navigates to history screen
-    markHistoryForRefreshAfterTransaction();
+    useHistoryStore.getState().markForRefreshAfterNavigation();


CassioMG · 2025-09-17T23:14:48Z

  isLoading: boolean;
  error: string | null;
  shouldRefreshAfterNavigation: boolean;
+  isFetching: boolean; // Track if a fetch is currently in progress


could we review/update the HistoryState JSDocs above?

CassioMG

Lgtm - left a few suggestions

feat: added history list store for better navigation

0df1951

danilosilvackl self-assigned this Sep 9, 2025

danilosilvackl added the enhancement New feature or request label Sep 9, 2025

danilosilvackl added this to the Freighter Mobile V1 - polishes milestone Sep 9, 2025

danilosilvackl requested review from CassioMG, aristidesstaffieri and leofelix077 September 9, 2025 00:09

leofelix077 reviewed Sep 11, 2025

View reviewed changes

CassioMG reviewed Sep 11, 2025

View reviewed changes

danilosilvackl added 7 commits September 17, 2025 10:16

Merge branch 'main' into ds-history-store

ff4d993

fix: centralized polling for history

d29cec1

fix: removed unecessary code for centralized polling on balancesList

remove extra empty lines

fa8b181

fix: improved fetching with Promise.all

6c1fa38

fix: wrong copy for preferences screen

a539932

fix: removed unecessary helper function

fix: avoid duplicated fetches

b79f22a

fix: improve pull to refresh area for low list items count

dca6ac9

CassioMG reviewed Sep 17, 2025

View reviewed changes

CassioMG approved these changes Sep 18, 2025

View reviewed changes

danilosilvackl added 3 commits September 18, 2025 09:00

fix: usage of history store

a1ee6af

fix: improved navigation fetch logic

7c41907

Merge branch 'main' into ds-history-store

3a1154d

danilosilvackl merged commit 48dc2ca into main Sep 18, 2025
4 checks passed

danilosilvackl deleted the ds-history-store branch September 18, 2025 14:08

github-actions Bot mentioned this pull request Nov 24, 2025

v1.9.24 #588

Closed


		const { fetchAccountBalances, getBalances } = useBalancesStore.getState();

		await fetchAccountBalances({

Conversation

danilosilvackl commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS 

Android 🤖

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danilosilvackl commented Sep 17, 2025

Before

After

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CassioMG left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danilosilvackl commented Sep 9, 2025 •

edited

Loading