BlockAid/Balances Scan and Fetch Rate adjustments by leofelix077 · Pull Request #505 · stellar/freighter-mobile

leofelix077 · 2025-10-27T20:17:50Z

closes #447

We were previously having rate limiting issues with Blockaid. It is known that they have already increased the rate limits on their APIs, but the improvements aim to ease it for the future as well. The 429 Errors were no longer reproducible by the time this ticket was started

Main changes are:

Increase balances polling from 30 to 60s and only when in focus
Instead of calling Bulk Scan again, extract BlockAid data from balances, which is already contained inside the returned data. No need for another set of scans
Increase debounce timer to 500ms instead of 200ms, to give users time to type more slowly without repeatedly calling the server. 200ms felt too quick for normal typing. The repeat requests would still trigger, unless typed very quickly

General Changes:

Screen.Recording.2025-10-28.at.09.25.41.mov

Returned data from balances:

Example of focused polling with start/stop logic on logs - set to 10s for testing, instead of 60s:

Screen.Recording.2025-10-28.at.10.39.58.mov

PR structure

This PR does not mix refactoring changes with feature changes (break it down into smaller PRs if not).
This PR has reasonably narrow scope (break it down into smaller PRs if not).
This PR includes relevant before and after screenshots/videos highlighting these changes.
I took the time to review my own PR.

Testing

These changes have been tested and confirmed to work as intended on Android.
These changes have been tested and confirmed to work as intended on iOS.
~~These changes have been tested and confirmed to work as intended on small iOS screens.~~
~~These changes have been tested and confirmed to work as intended on small Android screens.~~
I have tried to break these changes while extensively testing them.
This PR adds tests for the new functionality or fixes.

Release

This is not a breaking change.
This PR updates existing JSDocs when applicable.
This PR adds JSDocs to new functionalities.
I've checked with the product team if we should add metrics to these changes.
I've shared relevant before and after screenshots/videos highlighting these changes with the design team and they've approved the changes.

…passed since last focus

aristidesstaffieri · 2025-10-28T15:36:20Z

+            onPoll();
+            lastPollTimeRef.current = Date.now();
+
+            pollingIntervalIdRef.current = setInterval(() => {


it seems like this will overwrite the timeout ID with the polling ID, will the timeout ever get cleaned up in clearAllTimers?

added related comment here

it shouldn't be the case. the timers are cleared at the beginning of the useCallback before it gets overwritten

but how will it clear both references if one ID overrides the other?

aristidesstaffieri · 2025-10-28T15:38:21Z

-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [publicKey, network]);
+  useFocusedPolling({
+    onPoll: handlePoll,


lastPollTimeRef starts at 0 so this should also act as an initial fetch on mount, is the mount effect redundant?

CassioMG · 2025-10-28T18:49:51Z

      const [pricedBalances, scanResult] = await Promise.all([
        fetchPricedBalances(set, balances, statePricedBalances, params),
-        scanBalances(set, balances, params.network),
+        Promise.resolve(
+          extractScanResultsFromBalances(balances, params.network),
+        ),
      ]);


Suggested change

const [pricedBalances, scanResult] = await Promise.all([

fetchPricedBalances(set, balances, statePricedBalances, params),

scanBalances(set, balances, params.network),

Promise.resolve(

extractScanResultsFromBalances(balances, params.network),

),

]);

const pricedBalances = await fetchPricedBalances(set, balances, statePricedBalances, params);

const scanResults = extractScanResultsFromBalances(pricedBalances, params.network);

Would it be a good call to make something like this? So we assure the scanResults are always reflecting the most up to date balances (e.g. in case the user has just added a new token).

oh yes. makes sense

CassioMG · 2025-10-28T18:53:04Z

 export const DEFAULT_REFRESH_DELAY = 1000;

+// Balances polling interval in milliseconds
+export const BALANCES_FETCH_POLLING_INTERVAL = 60000;


since we are removing a redundant bulk-scan request on the frontend and only fetching on focus I think it'd be worth to keep it as 30secs so users don't need to wait too long to see a balance update

CassioMG · 2025-10-28T18:58:06Z

-      setHasAttemptedInitialLoad(true);
-      setIsMounting(false);


I don't remember exactly why we've added this in the past, but I'd suggest testing this branch with new account creations (with no balances) and also test switching between wallet accounts while observing if there won't be any weird UI glitches with spinners flickering or stuff like that

Seems like the behavior is close/the same to the main branch

Branch:

Screen.Recording.2025-10-29.at.12.54.33.mov

Main:

Screen.Recording.2025-10-29.at.12.57.20.mov

CassioMG · 2025-10-28T19:02:14Z

+      clearTimeout(pollingIntervalIdRef.current);
+      clearInterval(pollingIntervalIdRef.current);


it looks confusing to have the same ref be a Timeout and an Interval at the same time. Could we use separate refs here?

CassioMG · 2025-10-28T19:13:59Z

+          remainingTimeRef.current = interval;
+          startPolling(true);
+        } else {
+          pollingIntervalIdRef.current = setTimeout(() => {


could you add a comment explaining why we need to use setTimeout + setInterval here instead of calling startPolling(false)? Thanks

…ve redundant calls to fetchBalances

CassioMG · 2025-10-29T21:07:37Z

-      // Set the "raw" balances right away as they don't depend on prices
      set({
        balances,
        isFunded: isFunded ?? false,
        subentryCount: subentryCount ?? 0,
      });

-      // Get existing state priced balances to preserve price data


could we keep those comments? I think it helps clarifying things

leofelix077 added 3 commits October 27, 2025 13:52

adjust logic for polling on bulk scan and extract data from results

88fad50

rename tokens to benign

279399a

simplify useFocusedPolling function

ca4ce7c

leofelix077 added enhancement New feature or request wip work in progress don't review yet Work in Progress / Draft PR / Code Review adjustments being worked on labels Oct 27, 2025

add immediate fetch on scroll focus if more than polling intervl has …

8e91139

…passed since last focus

leofelix077 changed the title ~~[WIP] Lf bulk scan rate limit~~ BlockAid Scan Rate adjustments Oct 28, 2025

leofelix077 added 2 commits October 28, 2025 11:01

Merge branch 'main' into lf-bulk-scan-rate-limit

84ba91e

fix logic for focused polling start and stop logic

59d6183

leofelix077 changed the title ~~BlockAid Scan Rate adjustments~~ BlockAid/Balances Scan Rate adjustments Oct 28, 2025

leofelix077 changed the title ~~BlockAid/Balances Scan Rate adjustments~~ BlockAid/Balances Scan and Fetch Rate adjustments Oct 28, 2025

leofelix077 added 2 commits October 28, 2025 11:03

useFocusedPolling

69ea6d8

cleanup balance row mounting state

4d76f81

leofelix077 marked this pull request as ready for review October 28, 2025 14:08

leofelix077 removed wip work in progress don't review yet Work in Progress / Draft PR / Code Review adjustments being worked on labels Oct 28, 2025

leofelix077 requested review from CassioMG, aristidesstaffieri and piyalbasu October 28, 2025 14:08

aristidesstaffieri reviewed Oct 28, 2025

View reviewed changes

CassioMG reviewed Oct 28, 2025

View reviewed changes

leofelix077 added 2 commits October 29, 2025 12:21

fix interval ids references, add comment to start/stop logic and remo…

460fec6

…ve redundant calls to fetchBalances

add more comments to startPolling logic

a766a6b

leofelix077 self-assigned this Oct 29, 2025

CassioMG reviewed Oct 29, 2025

View reviewed changes

CassioMG approved these changes Oct 29, 2025

View reviewed changes

leofelix077 added 2 commits October 30, 2025 10:56

Merge branch 'main' into lf-bulk-scan-rate-limit

a5ceac4

add comments back regarding price balances set

ef1d767

leofelix077 merged commit 8cce6eb into main Oct 30, 2025
3 checks passed

leofelix077 deleted the lf-bulk-scan-rate-limit branch October 30, 2025 15:09

This was referenced Nov 7, 2025

v1.7.25 #550

Closed

v1.7.27 #551

Closed

v1.7.28 #552

Closed

v1.7.29 #553

Closed

v1.7.30 #554

Closed

v1.7.31 #555

Closed

v1.7.32 #556

Closed

github-actions Bot mentioned this pull request Nov 24, 2025

v1.9.24 #588

Closed

CassioMG mentioned this pull request May 2, 2026

Filter known Sentry noise from error tracking #814

Open

6 tasks

		clearTimeout(pollingIntervalIdRef.current);
		clearInterval(pollingIntervalIdRef.current);

Conversation

leofelix077 commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR structure

Testing

Release

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CassioMG Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leofelix077 commented Oct 27, 2025 •

edited

Loading

CassioMG Oct 28, 2025 •

edited

Loading