Conversation
CassioMG
requested review from
Brunonascdev,
aristidesstaffieri,
danilosilvackl and
piyalbasu
| network, | ||
| ); | ||
|
|
||
| // Set isMounting to false after the component mounts. |
Contributor
There was a problem hiding this comment.
maybe you could use a lifecycle state machine like we are starting to do in the extension, something like IDLE, PENDING, SUCCESS, ERROR. This could help stay away from having to use view sentinels values to step around the state.
aristidesstaffieri
approved these changes
Apr 1, 2025
Brunonascdev
approved these changes
Apr 1, 2025
danilosilvackl
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69
This PR adds the
FriendbotButtoncomponent which should only be shown and used onTestnet(or Futurenet once we add support for it) to fund recently created accounts with10000 XLM.This PR also fixes a small UI glitch that was causing the empty state to briefly blink for a fraction of second before displaying the balances spinner.
iOS
ios-friendbot.mp4
Android
android-friendbot.webm