Standardize coding style#154
Merged
morleyzhi merged 30 commits intostellar:masterfrom Feb 4, 2019
morleyzhi:mz-codestyle
Merged
Standardize coding style#154morleyzhi merged 30 commits intostellar:masterfrom morleyzhi:mz-codestyle
morleyzhi merged 30 commits intostellar:masterfrom
morleyzhi:mz-codestyle
Conversation
Contributor
|
Can you fix errors detected in CI before the review? |
added 9 commits
January 25, 2019 12:03
…s not, standardize on node 6
…n't native to babel 6; remove the custom watchers to use the existing one
bartekn
reviewed
Jan 29, 2019
| ], | ||
| "engines": { | ||
| "node": ">=4" | ||
| "node": ">=6.14.0" |
Contributor
There was a problem hiding this comment.
Any reason for 6.14? I think >=6 should be good.
Contributor
Author
There was a problem hiding this comment.
ESLint, possibly more tools, only support 6.14 and above. Since built files will be ES5ed, they'll still work on 6.0-6.13, but I guess we could miss some bugs that are fixed in 6.14. But I think that's pretty unlikely.
So the Travis files are set to install 6.14, and that's the version in NPM, so it makes sense to set the engine to the same value, since Babel could in the future use that to determine its transpile target.
Contributor
Author
|
@bartekn All the changes you suggested should be in now, thanks! |
Contributor
|
LGTM but please remove |
morleyzhi
added a commit
to stellar/js-xdr
that referenced
this pull request
Feb 4, 2019
Fixes #24. See also stellar/js-stellar-base#154 and stellar/js-stellar-sdk#221 - Add prettier and eslint (replacing jshint) - Add pre-commit hook for running prettier - Add Airbnb's eslint rules - Fix code with linter issues - Upgrade to Babel 6
bartekn
approved these changes
Feb 4, 2019
morleyzhi
added a commit
to stellar/js-stellar-sdk
that referenced
this pull request
Feb 4, 2019
Fixes #220. See also stellar/js-stellar-base#154. - Add prettier and eslint (replacing jshint) - Add pre-commit hook for running prettier - Add Airbnb's eslint rules - Fix code with linter issues - Fix jsdoc script - Travis changes: bump Node version Documentation needs improving, but that can be done in a later pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153. See also stellar/js-stellar-sdk#221.