Add negative test coverage for memo ID scientific notation and trailing decimal zero#940
Merged
sagpatil merged 2 commits intofix/tx-immutability-and-memo-id-validationfrom Mar 17, 2026
Conversation
…decimal zero Co-authored-by: sagpatil <1414227+sagpatil@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on mutable tx handle and memo ID validation fix
Add negative test coverage for memo ID scientific notation and trailing decimal zero
Mar 17, 2026
|
Size Change: 0 B Total Size: 3.53 MB ℹ️ View Unchanged
|
sagpatil
approved these changes
Mar 17, 2026
def1370
into
fix/tx-immutability-and-memo-id-validation
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Memo.id()validation fix (rejecting non-plain-decimal strings via/^\d+$/) lacked explicit regression tests for the two formats that motivated the fix: scientific notation and trailing decimal zeros — both accepted by BigNumber but fatal toBigInt()/UnsignedHyper.fromString().Changes
test/unit/memo_test.js— Added two negative assertions to the existingMemo.id()invalid-argument test block:"1e18"(scientific notation) — silently accepted by BigNumber, crashesUnsignedHyper"1.0"(trailing decimal zero) — same failure path📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.