Replace public/secret key field with SignerSelector#1968
Conversation
|
Preview is available here: |
There was a problem hiding this comment.
Pull request overview
This PR updates address/public-key inputs across the app to support selecting from saved keypairs and connected wallets via the existing SignerSelector, addressing issues around missing dropdowns and improving consistency.
Changes:
- Add
PubKeyPickerWithSignerSelectorand swap it into transaction op “source_account” and Sign Transaction signature public key inputs. - Enhance smart contract JSON schema
Addressprimitive inputs to include aSignerSelectordropdown. - Enable secret key selection dropdown in Sign Transaction’s secret key multipicker and add global positioning styles for selector wrappers.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/globals.scss | Adds .SignerSelectorWrapper positioning so selector dropdown can be absolutely positioned correctly. |
| src/components/formComponentTemplateTxnOps.tsx | Uses PubKeyPickerWithSignerSelector for operation source_account fields. |
| src/components/SmartContractJsonSchema/renderPrimitivesType.tsx | Wraps Address inputs with a SignerSelector-enabled input variant. |
| src/components/SignTransactionXdr/index.tsx | Enables secret key dropdown in MultiPicker and swaps signature public-key inputs to the new selector-enabled picker. |
| src/components/FormElements/PubKeyPickerWithSignerSelector.tsx | Introduces a reusable public key picker wrapped with SignerSelector. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
jeesunikim
force-pushed
the
issue-1703-1789-1845
branch
from
5acf6d1 to
f56d94f
Compare
|
Preview is available here: |
tackles #1703, #1789, #1845