Skip to content

quickstart: add soroban high limit override for standalone networks #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tsachiherman wants to merge 4 commits into from
Closed

quickstart: add soroban high limit override for standalone networks #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0698759
add high limit override for standalone networks.
tsachiherman Aug 31, 2023
143c13a
add to core node.
tsachiherman Aug 31, 2023
8774ce4
Merge branch 'master' into tsachi/add-high-limit-override
tsachiherman Sep 18, 2023
674d3f6
update per review feedback.
tsachiherman Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions standalone/core/etc/stellar-core.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ PUBLIC_HTTP_PORT=true
RUN_STANDALONE=__RUN_STANDALONE__
MANUAL_CLOSE=__MANUAL_CLOSE__
ARTIFICIALLY_ACCELERATE_TIME_FOR_TESTING=true
TESTING_SOROBAN_HIGH_LIMIT_OVERRIDE=__ENABLE_SOROBAN_HIGH_LIMIT_OVERRIDE__

NETWORK_PASSPHRASE="__NETWORK__"
KNOWN_CURSORS=["HORIZON"]
Expand Down
1 change: 1 addition & 0 deletions standalone/soroban-rpc/etc/stellar-captive-core.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ PEER_PORT=11726
DATABASE="__DATABASE__"
ARTIFICIALLY_ACCELERATE_TIME_FOR_TESTING=true
ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=__ENABLE_SOROBAN_DIAGNOSTIC_EVENTS__
TESTING_SOROBAN_HIGH_LIMIT_OVERRIDE=__ENABLE_SOROBAN_HIGH_LIMIT_OVERRIDE__

EXPERIMENTAL_BUCKETLIST_DB=true
EXPERIMENTAL_BUCKETLIST_DB_INDEX_PAGE_SIZE_EXPONENT=12
Expand Down
23 changes: 22 additions & 1 deletion start
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ export PGPORT=5432
: "${ENABLE_SOROBAN_DIAGNOSTIC_EVENTS:=false}"
: "${ENABLE_SOROBAN_RPC_ADMIN_ENDPOINT:=false}"
: "${ENABLE_CORE_MANUAL_CLOSE:=false}"
: "${ENABLE_SOROBAN_HIGH_LIMIT_OVERRIDE:=false}"
: "${ENABLE_STANDALONE_SOROBAN_HIGH_LIMIT_OVERRIDE:=true}"

QUICKSTART_INITIALIZED=false
CURRENT_POSTGRES_PID=""
Expand All @@ -53,6 +55,21 @@ function main() {
echo "--randomize-network-passphrase is only supported in the standalone network" >&2
exit 1
fi

# The disable-soroban-high-limit-override is available only for standalone networks.
# By default, we want to keep it enabled ( which is the default ) since we want to help developers
# having high execution limits.
if [ "$NETWORK" != "standalone" ] && [ "$ENABLE_STANDALONE_SOROBAN_HIGH_LIMIT_OVERRIDE" = "false" ]; then
echo "--disable-soroban-high-limit-override is only supported in the standalone network" >&2
exit 1
fi

# The value of ENABLE_STANDALONE_SOROBAN_HIGH_LIMIT_OVERRIDE would "propagete" into ENABLE_SOROBAN_HIGH_LIMIT_OVERRIDE
# only for standalone networks.
if [ "$NETWORK" = "standalone" ]; then
ENABLE_SOROBAN_HIGH_LIMIT_OVERRIDE=${ENABLE_STANDALONE_SOROBAN_HIGH_LIMIT_OVERRIDE}
fi

if [ "$ENABLE_LOGS" = "true" ]; then
print_service_logs &
start \
Expand Down Expand Up @@ -128,6 +145,9 @@ function process_args() {
--randomize-network-passphrase)
RANDOMIZE_NETWORK_PASSPHRASE=true
;;
--disable-soroban-high-limit-override)
ENABLE_STANDALONE_SOROBAN_HIGH_LIMIT_OVERRIDE=false
;;
*)
echo "Unknown container arg $ARG" >&2
exit 1
Expand Down Expand Up @@ -355,7 +375,7 @@ function init_stellar_core() {

run_silent "finalize-core-config-run-standalone" perl -pi -e "s/__RUN_STANDALONE__/$RUN_STANDALONE/g" etc/stellar-core.cfg
run_silent "finalize-core-config-manual-close" perl -pi -e "s/__MANUAL_CLOSE__/$ENABLE_CORE_MANUAL_CLOSE/g" etc/stellar-core.cfg

run_silent "finalize-core-config-enable-soroban-high-limit-override" perl -pi -e "s/__ENABLE_SOROBAN_HIGH_LIMIT_OVERRIDE__/$ENABLE_SOROBAN_HIGH_LIMIT_OVERRIDE/g" etc/stellar-core.cfg
start_postgres

run_silent "init-core-db" sudo -u stellar stellar-core new-db --conf etc/stellar-core.cfg
Expand Down Expand Up @@ -433,6 +453,7 @@ function init_soroban_rpc() {
run_silent "finalize-soroban-rpc-captivecore-db" perl -pi -e "s*__DATABASE__*sqlite3://$SOROBAN_RPC_HOME/captive-core/stellar-rpc.db*g" $SOROBAN_RPC_CAPTIVE_CORE_CFG
perl -pi -e "s/__NETWORK__/$NETWORK_PASSPHRASE/g" $SOROBAN_RPC_CAPTIVE_CORE_CFG
run_silent "finalize-core-config-enable-soroban-diagnostic-events" perl -pi -e "s/__ENABLE_SOROBAN_DIAGNOSTIC_EVENTS__/$ENABLE_SOROBAN_DIAGNOSTIC_EVENTS/g" $SOROBAN_RPC_CAPTIVE_CORE_CFG
run_silent "finalize-core-config-enable-soroban-high-limit-override" perl -pi -e "s/__ENABLE_SOROBAN_HIGH_LIMIT_OVERRIDE__/$ENABLE_SOROBAN_HIGH_LIMIT_OVERRIDE/g" $SOROBAN_RPC_CAPTIVE_CORE_CFG

local ADMIN_ENDPOINT=0.0.0.0:6061
if [ "$ENABLE_SOROBAN_RPC_ADMIN_ENDPOINT" != "true" ]; then
Expand Down