Add continue-on-error flag to test configuration #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
force-pushed
the
add-continue-on-error-test-config
branch
from
eb45fec to
2e13a85
Compare
sagpatil
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add continue-on-error flag to test configuration, allowing individual image test failures to be non-blocking. Restructure additional-tests under a tests object in images.json and update workflow to reference matrix.image properties. Enable continue-on-error for nightly and nightly-next builds while keeping it disabled for stable releases. Change the timeouts for tests.
Why
Nightly builds use bleeding-edge dependencies that may fail unpredictably, but these failures should not block the entire CI pipeline. Stable releases require strict test passing to ensure production readiness.
The timeouts were all over the place and not representative of how much time we actually expect the tests to pass. Some were super high because we use to run the tests for pubnet, but don't anymore. Setting the timeouts smaller but as a multiplier of run number in case we see failures and want to try rerunning to see if it just needed a little more time. Timeouts are now defined in the action which makes managing the configuration and visually identifying a timeout much easier in the GitHub UI.