Resolve external repo image inheritance from repo images.json #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables external repositories to inherit image configurations from the quickstart repository's images.json file. This allows third-party workflows to reuse base image definitions without duplicating configuration.
Key Changes:
- Extended
.scripts/images-resolve-inheritsto accept an optional parent file parameter for looking up inherited images - Added workflow step in
build.ymlto resolve image inheritance using the repository's images.json as the parent source - Updated build and test jobs to use the resolved images from the setup step
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.scripts/images-resolve-inherits |
Added optional parent file parameter and dual-lookup logic (input images take precedence over parent images) |
.github/workflows/build.yml |
Added "Resolve Inherits from Repo images.json" step and updated downstream jobs to use resolved images |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6 tasks
fnando
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add a setup step in the build workflow (called by other repos) to resolve image inheritance using the quickstart repository's images.json.
Why
Input images passed to the workflow from other repositories would benefit from being able to inherit from images defined in the quickstart repository's images.json, enabling reuse of base image configurations without duplicating them in every workflow input.
I had intended to implement this final step in #857 but missed it.
Close #856