Improve the way settings upgrade transactions are submitted#927
Merged
Improve the way settings upgrade transactions are submitted#927
Conversation
- actually switch/case on status code - retries on TRY_AGAIN_LATER - decompose into functions
Shaptic
force-pushed
the
reliable-upgrades
branch
from
9aa862f to
b8f0ec2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the local-network Soroban config upgrade flow in start by handling /tx submission status codes explicitly and adding retries for transient TRY_AGAIN_LATER responses, reducing upgrade flakiness during startup.
Changes:
- Added helper functions to submit Soroban config transactions with status-aware retry/abort behavior.
- Reworked the upgrade pipeline to wait for ledger transaction count advancement after each submitted config-upgrade transaction.
- Added retry logic when setting the
configUpgradeSetkey via the/upgradesendpoint.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sisuresh
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into an issue where I was seeing
TRY_AGAIN_LATERs during the upgrade process:This hardens that code path to actually react to the different
/txstatus codes.