Merged
Conversation
elizabethengelman
approved these changes
Sep 12, 2025
Member
|
system tests are passing locally… 🫠 $ ./dapp_develop_test.bin -test.v
=== RUN TestDappDevelop
Feature: DApp Contract Development
=== RUN TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract
Scenario Outline: DApp developer compiles, installs, deploys and invokes a contract # ./dapp_develop.feature:5
Given I used cargo to compile example contract <ContractExampleSubPath> # dapp_develop_test.go:322 -> github.com/stellar/system-test/features/dapp_develop.compileContractStep
And I used rpc to verify my account is on the network # dapp_develop_test.go:323 -> github.com/stellar/system-test/features/dapp_develop.queryAccountStep
And I used cli to install contract <ContractExampleSubPath> / <ContractCompiledFileName> on network using my secret key # dapp_develop_test.go:329 -> github.com/stellar/system-test/features/dapp_develop.installContractStep
And I used cli to deploy contract <ContractExampleSubPath> / <ContractCompiledFileName> by installed hash using my secret key # dapp_develop_test.go:330 -> github.com/stellar/system-test/features/dapp_develop.deployContractStep
When I invoke function <FunctionName> on <ContractName> with request parameters <FunctionParams> from tool <Tool> using my secret key # dapp_develop_test.go:334 -> github.com/stellar/system-test/features/dapp_develop.invokeContractStep
Then The result should be <Result> # dapp_develop_test.go:335 -> github.com/stellar/system-test/features/dapp_develop.theResultShouldBeStep
Examples:
| Tool | ContractExampleSubPath | ContractName | ContractCompiledFileName | FunctionName | FunctionParams | Result |
| NODEJS | hello_world | soroban-hello-world-contract | soroban_hello_world_contract.wasm | hello | to:Aloha | ["Hello","Aloha"] |
=== RUN TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract#01
| CLI | hello_world | soroban-hello-world-contract | soroban_hello_world_contract.wasm | hello | --to=Aloha | ["Hello","Aloha"] |
=== RUN TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract#02
| NODEJS | increment | soroban-increment-contract | soroban_increment_contract.wasm | increment | | 1 |
=== RUN TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract#03
| CLI | increment | soroban-increment-contract | soroban_increment_contract.wasm | increment | | 1 |
=== RUN TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract
Scenario Outline: DApp developer compiles, deploys and invokes a contract # ./dapp_develop.feature:21
Given I am using an rpc instance that has captive core config, ENABLE_SOROBAN_DIAGNOSTIC_EVENTS=true # dapp_develop_test.go:321 -> github.com/stellar/system-test/features/dapp_develop.noOpStep
And I used cargo to compile example contract <ContractExampleSubPath> # dapp_develop_test.go:322 -> github.com/stellar/system-test/features/dapp_develop.compileContractStep
And I used rpc to verify my account is on the network # dapp_develop_test.go:323 -> github.com/stellar/system-test/features/dapp_develop.queryAccountStep
And I used rpc to get network latest ledger # dapp_develop_test.go:324 -> github.com/stellar/system-test/features/dapp_develop.getNetworkStep
And I used cli to deploy contract <ContractExampleSubPath> / <ContractCompiledFileName> using my secret key # dapp_develop_test.go:331 -> github.com/stellar/system-test/features/dapp_develop.deployContractStep
When I invoke function <FunctionName> on <ContractName> with request parameters <FunctionParams> from tool <Tool> using my secret key # dapp_develop_test.go:334 -> github.com/stellar/system-test/features/dapp_develop.invokeContractStep
Then The result should be <Result> # dapp_develop_test.go:335 -> github.com/stellar/system-test/features/dapp_develop.theResultShouldBeStep
And The result should be to receive <EventCount> contract events for <ContractName> from <Tool> # dapp_develop_test.go:336 -> github.com/stellar/system-test/features/dapp_develop.theContractEventsShouldBeStep
Examples:
| Tool | ContractExampleSubPath | ContractName | ContractCompiledFileName | FunctionName | FunctionParams | Result | EventCount |
| NODEJS | hello_world | soroban-hello-world-contract | soroban_hello_world_contract.wasm | hello | to:Aloha | ["Hello","Aloha"] | 0 |
=== RUN TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract#01
| CLI | hello_world | soroban-hello-world-contract | soroban_hello_world_contract.wasm | hello | --to=Aloha | ["Hello","Aloha"] | 0 |
=== RUN TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract#02
| NODEJS | increment | soroban-increment-contract | soroban_increment_contract.wasm | increment | | 1 | 0 |
=== RUN TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract#03
=== RUN TestDappDevelop/DApp_developer_uses_config_states,_compiles,_deploys_and_invokes_contract_with_authorizations
Scenario Outline: DApp developer uses config states, compiles, deploys and invokes contract with authorizations # ./dapp_develop.feature:39
Given I used cargo to compile example contract <ContractExampleSubPath> # dapp_develop_test.go:322 -> github.com/stellar/system-test/features/dapp_develop.compileContractStep
And I used rpc to verify my account is on the network # dapp_develop_test.go:323 -> github.com/stellar/system-test/features/dapp_develop.queryAccountStep
And I used rpc to submit transaction to create tester account on the network # dapp_develop_test.go:325 -> github.com/stellar/system-test/features/dapp_develop.createTesterAccountStep
And I used cli to add Network Config <NetworkConfigName> for rpc and standalone # dapp_develop_test.go:326 -> github.com/stellar/system-test/features/dapp_develop.createNetworkConfigStep
And I used cli to add Identity <RootIdentityName> for my secret key # dapp_develop_test.go:327 -> github.com/stellar/system-test/features/dapp_develop.createMyIdentityStep
And I used cli to add Identity <TesterIdentityName> for tester secret key # dapp_develop_test.go:332 -> github.com/stellar/system-test/features/dapp_develop.createTestAccountIdentityStep
And I used cli to deploy contract <ContractExampleSubPath> / <ContractCompiledFileName> using Identity <RootIdentityName> and Network Config <NetworkConfigName> # dapp_develop_test.go:328 -> github.com/stellar/system-test/features/dapp_develop.deployContractUsingConfigParamsStep
When I invoke function <FunctionName> on <ContractName> with request parameters <FunctionParams> from tool <Tool> using Identity <TesterIdentityName> as invoker and Network Config <NetworkConfigName> # dapp_develop_test.go:333 -> github.com/stellar/system-test/features/dapp_develop.invokeContractStepWithConfig
Then The result should be <Result> # dapp_develop_test.go:335 -> github.com/stellar/system-test/features/dapp_develop.theResultShouldBeStep
Examples:
| Tool | ContractExampleSubPath | ContractName | ContractCompiledFileName | FunctionName | FunctionParams | RootIdentityName | TesterIdentityName | NetworkConfigName | Result |
| CLI | auth | soroban-auth-contract | soroban_auth_contract.wasm | increment | --user <tester_identity_pub_key> --value 2 | r1 | t1 | standalone | 2 |
9 scenarios (9 passed)
65 steps (65 passed)
3m49.317650541s
--- PASS: TestDappDevelop (229.32s)
--- PASS: TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract (39.50s)
--- PASS: TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract#01 (22.19s)
--- PASS: TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract#02 (26.19s)
--- PASS: TestDappDevelop/DApp_developer_compiles,_installs,_deploys_and_invokes_a_contract#03 (22.76s)
--- PASS: TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract (23.46s)
--- PASS: TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract#01 (23.98s)
--- PASS: TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract#02 (23.35s)
--- PASS: TestDappDevelop/DApp_developer_compiles,_deploys_and_invokes_a_contract#03 (20.97s)
--- PASS: TestDappDevelop/DApp_developer_uses_config_states,_compiles,_deploys_and_invokes_contract_with_authorizations (26.91s)
PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump version to 23.1.3, creating release branch.
Why
Triggered by @fnando in https://github.com/stellar/stellar-cli/actions/runs/17656860418.
What is next
See the release instructions for a full rundown on the release process:
https://github.com/stellar/actions/blob/main/README-rust-release.md
Commit any changes to the
release/v23.1.3branch that are needed in this release.If this is a regular release releasing from
main, merge this PR when ready, and after merging, create a release for this version by going to this link: https://github.com/stellar/stellar-cli/releases/new?tag=v23.1.3&title=23.1.3If this is a backport or patch release of a past version, see the release instructions. When ready to release this branch create a release by going to this link:
https://github.com/stellar/stellar-cli/releases/new?tag=v23.1.3&title=23.1.3&target=release/v23.1.3