Skip to content

chore: update sdk to published version, update sep5, and remove slipped10 dep#2473

Merged
fnando merged 3 commits intop26from
p26-remove-slip10
Apr 10, 2026
Merged

chore: update sdk to published version, update sep5, and remove slipped10 dep#2473
fnando merged 3 commits intop26from
p26-remove-slip10

Conversation

@mootz12
Copy link
Copy Markdown
Contributor

@mootz12 mootz12 commented Apr 10, 2026

What

Update the sep5 crate that also removed the slipped10 dependency in favor of ows_signer to 0.1.0. Also, manually implement the HD Path logic in stellar-ledger instead of relying on slipped10.

Why

The slipped10 dependency has a security advisory, and old, valid versions were yanked.

Known limitations

None

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the workspace to use published (crates.io) Soroban SDK crates and upgrades sep5 to remove the vulnerable slipped10 dependency, including an in-crate implementation of the Stellar BIP-44 HD path encoding used by stellar-ledger.

Changes:

  • Switch Soroban SDK-related workspace dependencies from git-based sources to crates.io versions.
  • Bump sep5 to 0.1.0 and remove slipped10 from stellar-ledger.
  • Replace slipped10-based BIP32 path handling in stellar-ledger with a manual hardened-path byte encoding (plus unit tests).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
deny.toml Updates allowed license list and removes now-unneeded duplicate-skip and git-source entries.
cmd/crates/stellar-ledger/src/hd_path.rs Implements manual Stellar HD path encoding and adds focused tests.
cmd/crates/stellar-ledger/Cargo.toml Drops the slipped10 dependency.
Cargo.toml Moves Soroban SDK deps to published versions and bumps sep5.
Cargo.lock Lockfile refresh reflecting the dependency upgrades/removals.

@fnando fnando merged commit fee2661 into p26 Apr 10, 2026
203 of 204 checks passed
@fnando fnando deleted the p26-remove-slip10 branch April 10, 2026 17:26
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants