chore: update sdk to published version, update sep5, and remove slipped10 dep#2473
Merged
chore: update sdk to published version, update sep5, and remove slipped10 dep#2473
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the workspace to use published (crates.io) Soroban SDK crates and upgrades sep5 to remove the vulnerable slipped10 dependency, including an in-crate implementation of the Stellar BIP-44 HD path encoding used by stellar-ledger.
Changes:
- Switch Soroban SDK-related workspace dependencies from git-based sources to crates.io versions.
- Bump
sep5to0.1.0and removeslipped10fromstellar-ledger. - Replace
slipped10-based BIP32 path handling instellar-ledgerwith a manual hardened-path byte encoding (plus unit tests).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
deny.toml |
Updates allowed license list and removes now-unneeded duplicate-skip and git-source entries. |
cmd/crates/stellar-ledger/src/hd_path.rs |
Implements manual Stellar HD path encoding and adds focused tests. |
cmd/crates/stellar-ledger/Cargo.toml |
Drops the slipped10 dependency. |
Cargo.toml |
Moves Soroban SDK deps to published versions and bumps sep5. |
Cargo.lock |
Lockfile refresh reflecting the dependency upgrades/removals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the
sep5crate that also removed theslipped10dependency in favor ofows_signerto0.1.0. Also, manually implement the HD Path logic instellar-ledgerinstead of relying onslipped10.Why
The
slipped10dependency has a security advisory, and old, valid versions were yanked.Known limitations
None