Reject non-ULID IDs in cache actionlog read command.#2499
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the cache actionlog read command to only accept ULID-formatted IDs, preventing non-ULID inputs from being used to construct cache file paths.
Changes:
- Parse the provided
--idas aulid::Ulidand reject invalid IDs with a dedicated error. - Build the actionlog cache file path from the normalized ULID string (
<ulid>.json). - Add unit tests to ensure path-traversal-like IDs (e.g.
../..., absolute paths) are rejected.
mootz12
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reject non-ULID IDs in cache actionlog read command.
Why
So we only accept valid ULIDs.
Known limitations
N/A