Skip to content

Stop reading from local config directory.#2500

Merged
fnando merged 6 commits intomainfrom
local-dir
Apr 21, 2026
Merged

Stop reading from local config directory.#2500
fnando merged 6 commits intomainfrom
local-dir

Conversation

@fnando
Copy link
Copy Markdown
Member

@fnando fnando commented Apr 20, 2026

What

Stop reading from local config directory. We're still checking for .stellar directories and warning about the required migration.

Why

To complete the removal from v26. Close #2493

Known limitations

N/A

@fnando fnando self-assigned this Apr 20, 2026
Copilot AI review requested due to automatic review settings April 20, 2026 22:33
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Apr 20, 2026
@fnando fnando moved this from Backlog (Not Ready) to Needs Review in DevX Apr 20, 2026
@fnando fnando requested review from mootz12 and removed request for Copilot April 20, 2026 22:33
Copilot AI review requested due to automatic review settings April 20, 2026 23:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the v26 removal of reading deprecated local config directories (e.g. .stellar), while still detecting their presence and warning users to migrate—addressing the --config-dir ancestor-search secret disclosure described in issue #2493.

Changes:

  • Make local-config discovery use the real process cwd (so --config-dir no longer seeds ancestor search).
  • Stop reading/listing identities and contract aliases from local config, but emit deprecation/migration warnings when local config is detected.
  • Update soroban-test integration helpers/tests to write/read identities from the global config directory layout.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
cmd/soroban-cli/src/config/locator.rs Avoids --config-dir ancestor-walk for local discovery; skips local reads/lists while warning; adds regression tests.
cmd/crates/soroban-test/tests/it/util.rs Updates test helper to write identities directly into the global config dir structure.
cmd/crates/soroban-test/tests/it/config.rs Adjusts integration tests to use sandbox.config_dir() paths and global-layout expectations.

Comment thread cmd/soroban-cli/src/config/locator.rs Outdated
Comment thread cmd/soroban-cli/src/config/locator.rs
Comment thread cmd/soroban-cli/src/config/locator.rs Outdated
Copy link
Copy Markdown
Contributor

@mootz12 mootz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving approval as this looks to address the linked issue, but wanted to flag that contract alias ls will still read from local dirs. If we want to address in a separate PR, could we create an issue?

@fnando fnando enabled auto-merge (squash) April 21, 2026 17:30
@fnando fnando merged commit 6043f0f into main Apr 21, 2026
210 checks passed
@fnando fnando deleted the local-dir branch April 21, 2026 17:36
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in DevX Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

--config-dir ancestor search discloses ancestor identity secrets outside the selected profile

3 participants