Fix permissions not reset on overwrite with --config-dir.#2501
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a high-severity security issue where overwriting existing identity files under --config-dir could preserve a previously-insecure Unix file mode (e.g., 0644), leaving newly-written signer secrets world-readable.
Changes:
- Explicitly chmod overwritten config files to
0600after writing (Unix). - Thread the active config root into
fix_config_permissions(...)so permission repair can target the correct directory. - Add a regression test ensuring overwrites reset file permissions to
0600.
mootz12
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix permissions not reset on overwrite with --config-dir.
Why
Close #2488
Known limitations
N/A