Skip to content

Honor --docker-host flag for TCP/HTTP Docker connections. #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fnando merged 3 commits into from
Apr 21, 2026
Merged

Honor --docker-host flag for TCP/HTTP Docker connections. #2503

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d5b241
Honor --docker-host flag for TCP/HTTP Docker connections.
fnando Apr 20, 2026
647c30b
Apply pr feedback.
fnando Apr 20, 2026
f6b2fd4
Merge branch 'main' into docker-host-bypass
fnando Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/soroban-cli/src/commands/container/shared.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ impl Args {
// this is based on the `connect_with_defaults` method which has not yet been released in the bollard crate
// https://github.com/fussybeaver/bollard/blob/0972b1aac0ad5c08798e100319ddd0d2ee010365/src/docker.rs#L660
let connection = match host.clone() {
// if tcp or http, use connect_with_http_defaults
// if tcp or http, connect to the specified host directly
// if unix and host starts with "unix://" use connect_with_unix
// if windows and host starts with "npipe://", use connect_with_named_pipe
// else default to connect_with_unix
h if h.starts_with("tcp://") || h.starts_with("http://") => {
Docker::connect_with_http_defaults()
Docker::connect_with_http(&h, DEFAULT_TIMEOUT, API_DEFAULT_VERSION)
}
#[cfg(unix)]
h if h.starts_with("unix://") => {
Expand Down
Loading