Reject STELLAR_SECRET_KEY when --secure-store is requested.#2504
Merged
Reject STELLAR_SECRET_KEY when --secure-store is requested.#2504
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a high-severity keys import footgun: when users explicitly request --secure-store, the CLI now rejects STELLAR_SECRET_KEY to prevent silently persisting the secret key in plaintext identity files (issue #2491).
Changes:
- Add a dedicated error for
--secure-store+STELLAR_SECRET_KEYconflict and enforce it inkeys addsecret resolution. - Reorder
read_secret()logic so--secure-storetakes precedence and fails closed when the env secret key is present. - Add an integration test ensuring the command fails and does not create an identity TOML file in this scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cmd/soroban-cli/src/commands/keys/add.rs |
Rejects STELLAR_SECRET_KEY when --secure-store is requested, preventing plaintext fallback. |
cmd/crates/soroban-test/tests/it/config.rs |
Adds an integration test to ensure the conflict is rejected and no identity file is created. |
mootz12
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reject STELLAR_SECRET_KEY when --secure-store is requested.
Why
Close #2491
Known limitations
N/A