Escape control characters in message sign preview.#2517
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the message sign output preview to escape (rather than remove) control characters so terminal control sequences (e.g., ESC) aren’t emitted in the preview.
Changes:
- Replaced control-character stripping with explicit escaping (
\xNN) in message sign preview output. - Updated
message signcommand to use the new escaping helper. - Strengthened the integration test to assert the escaped form appears in stderr.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/soroban-cli/src/utils.rs | Replaces the old control-character stripping helper with a new escaping implementation. |
| cmd/soroban-cli/src/commands/message/sign.rs | Switches preview rendering to use the new escaping helper. |
| cmd/crates/soroban-test/tests/it/message.rs | Adds an assertion that escaped ESC (\\x1b) appears in the preview output. |
leighmcculloch
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up on #2509 (comment)
Known limitations
[TODO or N/A]