Skip to content

Fix Windows build warnings in set_hardened_permissions.#2519

Merged
fnando merged 2 commits intomainfrom
fix-clippy-warning-on-windows
Apr 24, 2026
Merged

Fix Windows build warnings in set_hardened_permissions.#2519
fnando merged 2 commits intomainfrom
fix-clippy-warning-on-windows

Conversation

@fnando
Copy link
Copy Markdown
Member

@fnando fnando commented Apr 23, 2026

What

Fix Windows build warnings in set_hardened_permissions.

Why

So Windows builds can run cleanly.

Known limitations

N/A

Copilot AI review requested due to automatic review settings April 23, 2026 18:03
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Apr 23, 2026
@fnando fnando self-assigned this Apr 23, 2026
@fnando fnando moved this from Backlog (Not Ready) to Needs Review in DevX Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Windows build warnings in set_hardened_permissions within the Soroban CLI config locator, helping keep cross-platform builds clean.

Changes:

  • Adds a lint suppression attribute to avoid Windows-only unused-parameter / clippy warnings in set_hardened_permissions.

Comment thread cmd/soroban-cli/src/config/locator.rs
@fnando fnando merged commit 0d998c8 into main Apr 24, 2026
212 of 213 checks passed
@fnando fnando deleted the fix-clippy-warning-on-windows branch April 24, 2026 01:30
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in DevX Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants