Stop echoing message body to stderr when signing.#2520
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the message sign command to avoid leaking the message body via stderr output, addressing the referenced issue about unintended echoing during signing.
Changes:
- Remove the stderr “Message:” preview output from
message sign. - Add an integration test ensuring the message is not echoed to stderr (both argv and stdin paths).
- Adjust an existing control-character test to no longer expect an escaped preview.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/soroban-cli/src/commands/message/sign.rs | Stops printing the message content to stderr during signing. |
| cmd/crates/soroban-test/tests/it/message.rs | Adds a regression test for message non-echoing; modifies the control-character preview test assertions. |
leighmcculloch
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stop echoing message body to stderr when signing.
Why
Close https://github.com/stellar/stellar-cli-internal/issues/62
Known limitations
N/A