Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a secret-leak scenario where clap error messages could echo raw STELLAR_RPC_HEADERS / --rpc-header values by deferring header validation to application code and emitting a generic “invalid HTTP header” error instead.
Changes:
- Change
config::network::Argsto collect raw RPC headers asVec<String>and parse/validate later inArgs::get. - Add an “always succeeds” clap value parser for
Network::rpc_headersand introduceNetwork::validate_headers();network addnow calls it before writing config. - Add tests intended to ensure malformed header errors don’t expose secret values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| cmd/soroban-cli/src/config/network.rs | Defers RPC header parsing/validation to avoid clap echoing raw values; adds validation helpers and tests. |
| cmd/soroban-cli/src/commands/network/add.rs | Validates headers before persisting a network to config. |
mootz12
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Close https://github.com/stellar/stellar-cli-internal/issues/75
Known limitations
N/A