Redact password in cached RPC URLs.#2531
Merged
Merged
Conversation
leighmcculloch
approved these changes
Apr 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Redacts embedded passwords in RPC URLs when writing cached action-log entries, preventing credentials from being persisted to disk in the action-log cache.
Changes:
- Redact URL password component before serializing
rpc_urlinto the action-log JSON. - Add a helper to perform URL userinfo/password redaction.
- Expand/adjust tests to verify redaction behavior and avoid env var leakage via
with_env_set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Redact password in cached RPC URLs.
Why
Close https://github.com/stellar/stellar-cli-internal/issues/76
Known limitations
N/A