Remove dbug and gnome keyring support from Docker image#2544
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes DBus/gnome-keyring initialization from the Docker image so the container can run correctly under arbitrary non-root --user <uid>:<gid> setups (e.g., bind-mounted build workflows), and documents that --secure-store isn’t available in the container.
Changes:
- Delete
entrypoint.sh(previously started DBus and unlocked gnome-keyring) and set thestellarbinary as the Docker entrypoint directly. - Drop
dbus,gnome-keyring, and related DBus libraries from the Docker image install set. - Document in
docker/README.mdthat--secure-storeis unsupported in the container image.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
entrypoint.sh |
Removed DBus/keyring bootstrap that failed under non-root UIDs. |
docker/README.md |
Adds documentation clarifying --secure-store is not supported in the container. |
Dockerfile |
Removes DBus/keyring packages and sets stellar as the direct ENTRYPOINT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop dbus and gnome-keyring from the Docker image, remove entrypoint.sh, and set the stellar binary as the entrypoint directly. Document in docker/README.md that --secure-store is unsupported in the container.
Why
The previous entrypoint started dbus, which looked up the running UID in /etc/passwd and aborted under set -e when run with --user , breaking all non-root invocations including bind-mounted contract build flows. A keyring inside an ephemeral container has no useful role, so removing it is simpler than patching the UID lookup.
Close #2543