Skip to content

fix: prevent panic on no-op contract extend for non-existent entries #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toller892 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent panic on no-op contract extend for non-existent entries #2600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/soroban-cli/src/commands/contract/extend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,17 @@ impl Cmd {
if changes.is_empty() {
print.infoln("No changes detected, transaction was a no-op.");
let entry = client.get_full_ledger_entries(&keys).await?;
if entry.entries.is_empty() {
return Err(Error::LedgerEntryNotFound);
}
let extension = entry.entries[0].live_until_ledger_seq.unwrap_or_default();
Comment on lines +288 to 291

return Ok(TxnResult::Res(extension));
}

if changes.len() < 2 {
return Err(Error::LedgerEntryNotFound);
}
Comment on lines +296 to +298
match (&changes[0], &changes[1]) {
(
LedgerEntryChange::State(_),
Expand Down