Minor test fix

[marta-lokhova]

ubsan flagged a minor sorting bug in tests

[Copilot]

Pull request overview

Updates BannedAccountsPersistor tests to address a UBSan-reported ordering/sorting assumption.

Changes:

• Switches the “Keys are sorted” check in BannedAccountsPersistorTests to use getBannedAccounts() instead of getBannedAccountStrKeys().

Comments suppressed due to low confidence (1)

src/main/test/BannedAccountsPersistorTests.cpp:52

• persistor.getBannedAccounts() returns std::set<AccountID>, but this section still treats keys as a string container: std::find(..., addr1/addr2) (std::string) won’t compile against AccountID. Either keep using getBannedAccountStrKeys() here, or convert addr1/addr2 to AccountID and use keys.find(...) (and consider dropping/adjusting the std::is_sorted assertion since a std::set is already ordered).

        auto keys = persistor.getBannedAccounts();
        REQUIRE(keys.size() == 2);
        // Keys are sorted
        REQUIRE(std::is_sorted(keys.begin(), keys.end()));
        REQUIRE(std::find(keys.begin(), keys.end(), addr1) != keys.end());