Fix build issue with SharedMutex#5211
Merged
Merged
Conversation
sisuresh
approved these changes
Apr 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build issue when compiling with Tracy enabled by declaring mLedgerStateSnapshotMutex using the project’s Tracy-aware shared-mutex macro, keeping the mutex type consistent with the SharedLockShared / SharedLockExclusive helpers used throughout LedgerManagerImpl.
Changes:
- Replace a raw
SharedMutexmember withANNOTATED_SHARED_MUTEX(...)to correctly selecttracy::SharedLockable<std::shared_mutex>underUSE_TRACY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes minor build issue with tracy flags.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)