Skip to content

Allow DATABASE config in file#5219

Merged
sisuresh merged 1 commit into
stellar:masterfrom
sisuresh:db-secret
Apr 10, 2026
Merged

Allow DATABASE config in file#5219
sisuresh merged 1 commit into
stellar:masterfrom
sisuresh:db-secret

Conversation

@sisuresh
Copy link
Copy Markdown
Contributor

Description

Extension on #5177

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@sisuresh sisuresh marked this pull request as ready for review April 10, 2026 17:22
Copilot AI review requested due to automatic review settings April 10, 2026 17:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the existing “external secret” ($FILE:) resolution mechanism to support loading the DATABASE connection string from a file, aligning database configuration with other secret-handling config fields.

Changes:

  • Resolve DATABASE via secretmanager::resolve() during config processing (supporting $FILE:).
  • Add config tests covering $FILE:-based DATABASE and inline backward compatibility.
  • Document $FILE: usage for DATABASE in the example configuration.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/main/Config.cpp Resolves DATABASE via secret manager and flags external secret usage.
src/main/test/ConfigTests.cpp Adds tests for $FILE:-based DATABASE and inline DATABASE.
docs/stellar-core_example.cfg Documents $FILE:-based DATABASE configuration and permission expectations.

Comment thread src/main/Config.cpp
Comment thread docs/stellar-core_example.cfg
Comment thread src/main/test/ConfigTests.cpp
Comment thread src/main/test/ConfigTests.cpp Outdated
@sisuresh sisuresh added this pull request to the merge queue Apr 10, 2026
Merged via the queue into stellar:master with commit af0031e Apr 10, 2026
53 checks passed
@sisuresh sisuresh deleted the db-secret branch April 10, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants