Cleanups#5234
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes a few small overlay/network “cleanup” adjustments, improving robustness of advert batching, tightening AUTH processing order, and bumping the overlay protocol version constant.
Changes:
- Flush outgoing tx adverts when the queue size exceeds (not only equals) the computed max advert size.
- Move the AUTH flow-control-flag validation earlier in
Peer::recvAuth()(before peer record update / acceptance). - Bump
OVERLAY_PROTOCOL_VERSIONfrom 40 to 41.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/overlay/TxAdverts.cpp | Makes advert flushing resilient to cases where the queue can exceed the computed threshold. |
| src/overlay/Peer.cpp | Reorders AUTH validation to reject incompatible peers before updating/accepting them. |
| src/main/Config.cpp | Updates the configured maximum overlay protocol version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/stellar/stellar-core-internal/issues/563
Resolves https://github.com/stellar/stellar-core-internal/issues/506