Skip to content

Revert "Run soroban on large stacks"#5253

Merged
dmkozh merged 1 commit into
stellar:masterfrom
dmkozh:thread_revert
May 8, 2026
Merged

Revert "Run soroban on large stacks"#5253
dmkozh merged 1 commit into
stellar:masterfrom
dmkozh:thread_revert

Conversation

@dmkozh
Copy link
Copy Markdown
Contributor

@dmkozh dmkozh commented May 6, 2026

Description

Revert "Run soroban on large stacks".

This reverts commit c37030d.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

Copilot AI review requested due to automatic review settings May 6, 2026 18:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the earlier change that executed Soroban host-function invocation on a newly spawned Rust thread with an explicitly large stack, returning execution to the caller’s existing thread/stack.

Changes:

  • Remove the scoped thread spawn + 100MiB stack configuration around Soroban host invocation.
  • Remove the associated error-type remapping that existed solely to cross the thread boundary.

Comment thread src/rust/src/soroban_invoke.rs
@dmkozh dmkozh requested a review from graydon May 6, 2026 19:47
Copy link
Copy Markdown
Contributor

@graydon graydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enthusiastically approved!

@dmkozh dmkozh enabled auto-merge May 8, 2026 18:41
@dmkozh dmkozh added this pull request to the merge queue May 8, 2026
Merged via the queue into stellar:master with commit c852f5b May 8, 2026
54 checks passed
@dmkozh dmkozh deleted the thread_revert branch May 8, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants